BUG: File expansion when updating with Page Contents #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to install |
|
Thank you for the quick fix 🙏 |
MartinThoma
reviewed
Jun 22, 2023
MartinThoma
reviewed
Jun 22, 2023
MartinThoma
reviewed
Jun 22, 2023
MartinThoma
reviewed
Jun 22, 2023
Co-authored-by: Martin Thoma <[email protected]>
Co-authored-by: Martin Thoma <[email protected]>
Co-authored-by: Martin Thoma <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
==========================================
+ Coverage 93.81% 93.83% +0.01%
==========================================
Files 34 34
Lines 6922 6943 +21
Branches 1365 1370 +5
==========================================
+ Hits 6494 6515 +21
- Misses 280 282 +2
+ Partials 148 146 -2
☔ View full report in Codecov by Sentry. |
|
Now coverage to be improve. give me a coupe of hours for dinner 😋 |
|
looks good now! |
MartinThoma
changed the title
|
Very nice! Thank you :-) |
MartinThoma
added a commit
that referenced
this pull request
Jun 23, 2023
New Features (ENH): - Add page_number property (#1856) Bug Fixes (BUG): - File expansion when updating with Page Contents (#1906) - Missing Alternate in indexed/ICCbased colorspaces (#1896) [Full Changelog](3.10.0...3.11.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1897