Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROB: Handle missing /Type entry in Page tree #1859

Merged
merged 2 commits into from
Jun 3, 2023

Conversation

pubpub-zz
Copy link
Collaborator

@pubpub-zz pubpub-zz commented May 23, 2023

Forgot that the code modified in #1845 was duplicated in PdfWriter

pubpub-zz added 2 commits May 23, 2023 11:58
Forgot that the code was duplicated
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0096c99) 93.42% compared to head (c7f2f2e) 93.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1859   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files          34       34           
  Lines        6632     6634    +2     
  Branches     1302     1303    +1     
=======================================
+ Hits         6196     6198    +2     
  Misses        284      284           
  Partials      152      152           
Impacted Files Coverage Δ
pypdf/_writer.py 87.64% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma

all yours

@MartinThoma MartinThoma changed the title Apply fix from #1845 on PdfWriter ROB: Handle missing /Type entry in Page tree Jun 3, 2023
@MartinThoma MartinThoma added the is-robustness-issue From a users perspective, this is about robustness label Jun 3, 2023
@MartinThoma MartinThoma merged commit 81a58da into py-pdf:main Jun 3, 2023
@MartinThoma
Copy link
Member

Thank you 🙏

MartinThoma added a commit that referenced this pull request Jun 4, 2023
Deprecations (DEP)
-  Deprecate PdfMerger (#1866)

Bug Fixes (BUG)
-  Ignore UTF-8 decode errors (#1865)

Robustness (ROB)
-  Handle missing /Type entry in Page tree (#1859)

[Full Changelog](3.9.0...3.9.1)
@pubpub-zz pubpub-zz deleted the 1845b branch September 2, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-robustness-issue From a users perspective, this is about robustness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants