-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add transform method to Transformation #1765
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 34 34
Lines 6609 6612 +3
Branches 1302 1302
=======================================
+ Hits 6146 6149 +3
Misses 302 302
Partials 161 161
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I'm open to adding this 👍 What do you think @pubpub-zz ? |
sounds good to me too. |
@rrthomas |
|
Thank you for your contribution @rrthomas! If you want, I'll also add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html |
The PR was just merged to |
Thanks very much, I'd be delighted to be added to the contributors list, and I look forward to using the release! |
New Features (ENH) - Add transform method to Transformation class (#1765) - Cope with UC2 fonts in text_extraction (#1785) Robustness (ROB) - Invalid startxref pointing 1 char before (#1784) Maintenance (MAINT) - Mark code handling old parameters as deprecated (#1798) [Full Changelog](3.7.1...3.8.0)
I am the maintainer of PSUtils. I am adding PDF support, and rewriting the code in Python. pyPDF was a significant motivation for the choice of language, so thanks for that!
I need to express vertical and horizontal page flips, and the simplest way to achieve this seemed to be to add a general
transform
method toTransformation
(I need all the different sorts of transformations to be applied repeatedly to the same page, so it's easier to change aTransformation
than to make multiple copies of a page and transform that.) I have done this in the simplest way I could; it might be desired for the method to take aCompressedTransformationMatrix
too.If you agree to add an API something like this, I'll happily add some tests. (At the moment I just tested it with my experimental PSUtils code.)