ENH: Add clone_from parameter in PdfWriter constructor #1703
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
=======================================
Coverage 92.50% 92.51%
=======================================
Files 34 34
Lines 6512 6516 +4
Branches 1286 1288 +2
=======================================
+ Hits 6024 6028 +4
Misses 316 316
Partials 172 172
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
all yours |
|
I don't know if you are waiting for this... but it's all yours 😉 |
|
Should we deprecate In general, I think it's a good idea to have only one way to do one thing. This way the code looks more consistent (both internally and externally) |
why not.However my only point would be to not break compatibility for existing programs. |
|
Yes, I also don't want to break peoples workflows. If we do it, we should use the deprecation workflow. So |
MartinThoma
changed the title
|
Thank you for the PR @pubpub-zz ❤️ |
Security (SEC): - Use Python's secrets module instead of random module (#1748) New Features (ENH): - Add AnnotationBuilder.highlight text markup annotation (#1740) - Add AnnotationBuilder.popup (#1665) - Add AnnotationBuilder.polyline annotation support (#1726) - Add clone_from parameter in PdfWriter constructor (#1703) Bug Fixes (BUG): - 'DictionaryObject' object has no attribute 'indirect_reference' (#1729) Robustness (ROB): - Handle params NullObject in decode_stream_data (#1738) Documentation (DOC): - Project scope (#1743) Maintenance (MAINT): - Add AnnotationFlag (#1746) - Add LazyDict.__str__ (#1727) [Full Changelog](3.6.0...3.7.0)
add a parameter to ease edition of pdf