BUG: Switch from trimbox to cropbox when merging pages

[MartinThoma]

@pubpub-zz Continuing our discussion from #879 and #1426 :-)

I'm not sure if exposing this that prominently is a good idea or if we should simply change it... but allowing people to easily switch back would potentially enable people to still get the old behavior if they need to

I also don't know if MERGE_CROP_BOX is a good name for this attribute.

[codecov]

Codecov Report

Base: 91.92% // Head: 91.92% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (42a61ce) compared to base (f5ac79b).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 42a61ce differs from pull request most recent head 28e96cd. Consider uploading reports for the commit 28e96cd to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1622   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files          33       33           
  Lines        6374     6375    +1     
  Branches     1272     1272           
=======================================
+ Hits         5859     5860    +1     
  Misses        327      327           
  Partials      188      188           

Impacted Files	Coverage Δ
pypdf/_page.py	90.54% <100.00%> (+0.01%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pubpub-zz]

I like your idea. 👏👏👏
about the name It does not sound too bad. just a few line at the bottom of https://pypdf.readthedocs.io/en/latest/user/cropping-and-transforming.html should be sufficient

PS : I would be interested in a quick merge in order to upgrade the remaining merges identified in #1615

[MartinThoma]

@pubpub-zz Merged :-) Thanks for pointing out that MERGE_CROP_BOX should be in the docs 👍 And thanks for bringing up this topic multiple times 😄