MAINT: position ➔ page_number in Merger.merge

[Infus3d]

Changed method parameter name for consistency as mentioned in #1187

• position ➔ page_number in PdfMerger.merge

Improved the deprecation message of:

• dest ➔ page_destination in PdfWriter.add_outline_item_destination and PdfWriter.add_named_destination_object
• user_pwd ➔ user_password and owner_pwd ➔ owner_password in PdfWriter.encrypt

[MartinThoma]

Thank you for the pr 🙏

I recommend to use pre-commit as it fixes some style issues:

# install pre-commit
pip install pre-commit

# within the PyPDF2 repository, install the pre-commit hooks:
pre-commit install

[MartinThoma]

I'll merge #1467 before this one

[Infus3d]

I thought the tests were running fine locally. Do you have an idea why the check is failing by chance?

[MartinThoma]

this is a breaking change as you moved the position of the argument. Not everybody uses keyword-arguments.

[codecov]

Codecov Report

Base: 94.12% // Head: 94.14% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7de7c4b) compared to base (a0abf1e).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7de7c4b differs from pull request most recent head 3d1deb2. Consider uploading reports for the commit 3d1deb2 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
+ Coverage   94.12%   94.14%   +0.01%     
==========================================
  Files          30       30              
  Lines        5447     5445       -2     
  Branches     1039     1038       -1     
==========================================
- Hits         5127     5126       -1     
  Misses        191      191              
+ Partials      129      128       -1     

Impacted Files	Coverage Δ
PyPDF2/_merger.py	93.18% <100.00%> (-0.03%)	⬇️
PyPDF2/_writer.py	89.55% <100.00%> (+0.13%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Infus3d]

I changed the order back, it should be fine now. Although the workaround is a bit cheap, it is the only way I can think of. 😅

[MartinThoma]

Thank you @Infus3d !

edit: I've just fixed the merge conflicts.