Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : ToUnicode stores /Identity-H instead of stream #1433

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

pubpub-zz
Copy link
Collaborator

@pubpub-zz pubpub-zz commented Nov 13, 2022

fixes #1417

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 94.25% // Head: 94.24% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (06e06a8) compared to base (6a61089).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   94.25%   94.24%   -0.02%     
==========================================
  Files          28       28              
  Lines        5086     5090       +4     
  Branches      968      970       +2     
==========================================
+ Hits         4794     4797       +3     
  Misses        177      177              
- Partials      115      116       +1     
Impacted Files Coverage Δ
PyPDF2/_cmap.py 95.23% <83.33%> (-0.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit 56395e9 into py-pdf:main Nov 18, 2022
@MartinThoma
Copy link
Member

Thank you for taking care of it - and sorry that it took me so long 🙈

I'll make a release this weekend :-)

@MartinThoma
Copy link
Member

I'm having my wedding in December and I have to move apartments - it's quite a lot at the moment

@pubpub-zz
Copy link
Collaborator Author

Congratulations!!!!🎉🎉🎉🎉

@pubpub-zz pubpub-zz deleted the iss1417 branch June 24, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NameObject' object has no attribute 'get_data' when running extract_text on page of pdf
2 participants