-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV: Improve error reporting of read_object #1412
Conversation
@MartinThoma |
@MartinThoma |
Codecov ReportBase: 94.19% // Head: 94.18% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
- Coverage 94.19% 94.18% -0.02%
==========================================
Files 28 28
Lines 5085 5086 +1
Branches 968 968
==========================================
Hits 4790 4790
- Misses 176 177 +1
Partials 119 119
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Overall, this PR looks good and I'll merge it after CI succeeds. Regarding the timing-test: I think we should get rid of the time-checking unit tests (and never do that again). At least if the difference is not huge. In this case, the factor seems to be 5-10, and thus it's too brittle. Benchmarks are a completely different story. This test might a good candidate to move to https://py-pdf.github.io/PyPDF2/dev/bench/ |
Additionally, use
time.process_time
instead oftime.time
fortest_readStringFromStream_performance