ROB: Cope with str returned from get_data in cmap #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes py-pdf#1379 have not been able to identify why str is returned instead of bytes as usual prefer to convert locally
Codecov ReportBase: 94.12% // Head: 94.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 28 28
Lines 5072 5074 +2
Branches 1052 966 -86
=======================================
+ Hits 4774 4776 +2
Misses 177 177
Partials 121 121
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
ready to merge |
MartinThoma
changed the title
|
Thank you ❤️ I'll make a release to PyPI either today or tomorrow :-) |
MartinThoma
added a commit
that referenced
this pull request
Oct 10, 2022
Bug Fixes (BUG): - td matrix (#1373) - Cope with cmap from #1322 (#1372) Robustness (ROB): - Cope with str returned from get_data in cmap (#1380) Full Changelog: 2.11.0...2.11.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1379
have not been able to identify why str is returned instead of bytes as usual prefer to convert locally