Add min version for typing_extensions requirement #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I stumbled upon this while having an older typing_extensions version installed. According to my investigation TypeAlias was introduced with typing_extensions 3.10.0 which makes sense since it is a Python 3.10 feature.
Codecov Report
@@ Coverage Diff @@
## main #1277 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 30 30
Lines 4966 4966
Branches 1022 1022
=======================================
Hits 4714 4714
Misses 141 141
Partials 111 111 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Applying this dependency manually to my installation solved my problem. Thanks! 🚀 |
|
Thank you! Yes, that makes a lot of sense! python/typing_extensions@d362ccb added TypeAlias and that seems to be 3.10.0.0. Looks good to me! |
|
@Shortfinga If you want, I can add you to https://pypdf2.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-) The change will be released to PyPI tomorrow |
MartinThoma
added a commit
that referenced
this pull request
Aug 28, 2022
Robustness (ROB): - Fix errors/warnings on no /Resources within extract_text (#1276) - Add required line separators in ContentStream ArrayObjects (#1281) Maintenance (MAINT): - Use NameObject idempotency (#1290) Testing (TST): - Rectangle deletion (#1289) - Add workflow tests (#1287) - Remove files after tests ran (#1286) Packaging (PKG): - Add minimum version for typing_extensions requirement (#1277) Full Changelog: 2.10.3...2.10.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon this while having an older typing_extensions version
installed. According to my investigation TypeAlias was introduced with
typing_extensions 3.10.0 which makes sense since it is a Python 3.10
feature.