Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Allow IndirectObjects as stream filters #1211

Merged
merged 1 commit into from
Aug 6, 2022
Merged

BUG: Allow IndirectObjects as stream filters #1211

merged 1 commit into from
Aug 6, 2022

Conversation

MartinThoma
Copy link
Member

@MartinThoma MartinThoma commented Aug 6, 2022

According to 'TABLE 3.4 Entries common to all stream dictionaries', no IndirectObject is expected there.

But also:

Any object in a PDF file may be labeled as an indirect object.

Closes #399

@MartinThoma MartinThoma added the is-robustness-issue From a users perspective, this is about robustness label Aug 6, 2022
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #1211 (80fb495) into main (cb3f66e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1211   +/-   ##
=======================================
  Coverage   92.15%   92.16%           
=======================================
  Files          24       24           
  Lines        4948     4950    +2     
  Branches     1024     1025    +1     
=======================================
+ Hits         4560     4562    +2     
  Misses        244      244           
  Partials      144      144           
Impacted Files Coverage Δ
PyPDF2/filters.py 95.35% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MartinThoma MartinThoma changed the title ROB: Allow IndirectObjects as stream filters BUG: Allow IndirectObjects as stream filters Aug 6, 2022
@MartinThoma MartinThoma added is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF and removed is-robustness-issue From a users perspective, this is about robustness labels Aug 6, 2022
Closes #399

See 'TABLE 3.4 Entries common to all stream dictionaries'
@MartinThoma MartinThoma merged commit 5b6bffb into main Aug 6, 2022
@MartinThoma MartinThoma deleted the issue-399 branch August 6, 2022 13:48
MartinThoma added a commit that referenced this pull request Aug 7, 2022
New Features (ENH):
-  "with" support for PdfMerger and PdfWriter (#1193)
-  Add AnnotationBuilder.text(...) to build text annotations (#1202)

Bug Fixes (BUG):
-  Allow IndirectObjects as stream filters (#1211)

Documentation (DOC):
-  Font scrambling
-  Page vs Content scaling (#1208)
-  Example for orientation parameter of extract_text (#1206)
-  Fix AnnotationBuilder parameter formatting (#1204)

Developer Experience (DEV):
-  Add flake8-print (#1203)

Maintenance (MAINT):
-  Introduce WrongPasswordError / FileNotDecryptedError / EmptyFileError  (#1201)

Full Changelog: 2.9.0...2.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndirectObject has no len()
1 participant