BUG: Let Page.scale also scale the crop-/trim-/bleed-/artbox #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unclear if all of the other boxes should be scaled as well. I think so. Is there any reason not to do tha? |
Codecov Report
@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
+ Coverage 90.86% 90.87% +0.01%
==========================================
Files 24 24
Lines 4508 4514 +6
Branches 920 920
==========================================
+ Hits 4096 4102 +6
Misses 271 271
Partials 141 141
Continue to review full report at Codecov.
|
|
|
MartinThoma
force-pushed
the
doc-scale
branch
2 times, most recently
from
5db7d0a to
ec43342
Compare
Closes #272 Co-authored-by: Brian Painter <[email protected]>
MartinThoma
changed the title
MartinThoma
added
the
is-bug
MartinThoma
changed the title
MartinThoma
changed the title
MartinThoma
added a commit
that referenced
this pull request
Jul 10, 2022
New Features (ENH): - Add PageObject._get_fonts (#1083) - Add support for indexed color spaces / BitsPerComponent for decoding PNGs (#1067) Performance Improvements (PI): - Use iterative DFS in PdfWriter._sweep_indirect_references (#1072) Bug Fixes (BUG): - Let Page.scale also scale the crop-/trim-/bleed-/artbox (#1066) - Column default for CCITTFaxDecode (#1079) Robustness (ROB): - Guard against None-value in _get_outlines (#1060) Documentation (DOC): - Stamps and watermarks (#1082) - OCR vs PDF text extraction (#1081) - Python Version support - Formatting of CHANGELOG Developer Experience (DEV): - Cache downloaded files (#1070) - Speed-up for CI (#1069) Maintenance (MAINT): - Set page.rotate(angle: int) (#1092) - Issue #416 was fixed by #1015 (#1078) Testing (TST): - Image extraction (#1080) - Image extraction (#1077) Code Style (STY): - Apply black - Typo in Changelog Full Changelog: 2.4.2...2.4.3
|
@MartinThoma this looks like a good improvement. I'm not an expert on PDFs and the different boxes, but I used this guide previously to try and understand them: https://www.prepressure.com/pdf/basics/page-boxes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #272