Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Deduplicate Code #1022

Merged
merged 14 commits into from
Jun 29, 2022
Merged

MAINT: Deduplicate Code #1022

merged 14 commits into from
Jun 29, 2022

Conversation

MartinThoma
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1022 (9dec032) into main (eedf0e0) will increase coverage by 0.31%.
The diff coverage is 96.51%.

@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
+ Coverage   89.62%   89.93%   +0.31%     
==========================================
  Files          24       24              
  Lines        4462     4482      +20     
  Branches      922      916       -6     
==========================================
+ Hits         3999     4031      +32     
+ Misses        314      308       -6     
+ Partials      149      143       -6     
Impacted Files Coverage Δ
PyPDF2/_writer.py 88.83% <70.00%> (+0.07%) ⬆️
PyPDF2/_merger.py 92.53% <100.00%> (+3.72%) ⬆️
PyPDF2/_reader.py 91.77% <100.00%> (+0.03%) ⬆️
PyPDF2/constants.py 100.00% <100.00%> (ø)
PyPDF2/generic.py 91.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85c7e7...9dec032. Read the comment docs.

@MartinThoma MartinThoma merged commit d1f2ed2 into main Jun 29, 2022
@MartinThoma MartinThoma deleted the constants branch June 29, 2022 20:32
MartinThoma added a commit that referenced this pull request Jun 30, 2022
New Features (ENH):
-  Add writer.pdf_header property (getter and setter) (#1038)

Performance Improvements (PI):
-  Remove b_ call in FloatObject.write_to_stream (#1044)
-  Check duplicate objects in writer._sweep_indirect_references (#207)

Documentation (DOC):
-  How to surppress exceptions/warnings/log messages (#1037)
-  Remove hyphen from lossless (#1041)
-  Compression of content streams (#1040)
-  Fix inconsistent variable names in add-watermark.md (#1039)
-  File size reduction
-  Add CHANGELOG to the rendered docs (#1023)

Maintenance (MAINT):
-  Handle XML error when reading XmpInformation (#1030)
-  Deduplicate Code / add mutmut config (#1022)

Code Style (STY):
-  Use unnecessary one-line function / class attribute (#1043)
-  Docstring formatting (#1033)

Full Changelog: 2.4.0...2.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant