BUG: Fix missing page for bookmark #1016
Conversation
|
Using from PyPDF2 import PdfMerger
merger = PdfMerger()
merger.append("crazyones.pdf")
bookmark = merger.add_bookmark("A bookmark", 0)
bm2 = merger.add_bookmark("deeper", 1, parent=bookmark)
merger.write("issue968.pdf")
merger.close()The first level has a bookmark, but the second has not:
|
MartinThoma
force-pushed
the
missing-bookmark
branch
from
66e886a to
fbe2a0f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
+ Coverage 89.30% 89.34% +0.03%
==========================================
Files 24 24
Lines 4443 4420 -23
Branches 921 917 -4
==========================================
- Hits 3968 3949 -19
+ Misses 323 321 -2
+ Partials 152 150 -2
Continue to review full report at Codecov.
|
|
The issue with the second page was simply that I specified page index 1, but only index 0 exists. After fixing it, the nested one worked. |
|
Your PR description does not make sense to me, as I'd hope that a yet to be merged PR does not introduce a bug that's existed since before the PR existed. Did you mean to reference 07848e5? |
|
@MasterOdin Thank you for the hint - I wanted to references #339 |
|
@pubpub-zz Do you think this PR ok? |
|
Sorry I missed this messsge |
|
I've tried it with the indirect object, but that failed for the PdfMerger. I don't know why. |
|
the referencing of the page into the xref (in order to define the object number seems to be done when writing. A little complex to find solution in a few minutes. Let's wait for a new issue to clarify I'm right or wrong |
MartinThoma
added
the
is-bug
New Features (ENH): - Support R6 decrypting (#1015) - Add PdfReader.pdf_header (#1013) Performance Improvements (PI): - Remove ord_ calls (#1014) Bug Fixes (BUG): - Fix missing page for bookmark (#1016) Robustness (ROB): - Deal with invalid Destinations (#1028) Documentation (DOC): - get_form_text_fields does not extract dropdown data (#1029) - Adjust PdfWriter.add_uri docstring - Mention crypto extra_requires for installation (#1017) Developer Experience (DEV): - Use /n line endings everywhere (#1027) - Adjust string formatting to be able to use mutmut (#1020) - Update Bug report template Full Changelog: 2.3.1...2.4.0
Closes #968 (introduced with #339)