Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Add body to created GitHub release #1971

Closed
MartinThoma opened this issue Jul 16, 2023 · 0 comments · Fixed by #1985
Closed

DEV: Add body to created GitHub release #1971

MartinThoma opened this issue Jul 16, 2023 · 0 comments · Fixed by #1985
Assignees
@MartinThoma
Labels
Meta

Comments

@MartinThoma
Copy link
Member

This is a follow-up on #1970.

At the moment, when I create a git tag it properly creates + uploads the package to PyPI.

It also creates a Github release with the correct title. But the body is missing.

See also: https://stackoverflow.com/q/76699485/562769
@MartinThoma MartinThoma self-assigned this Jul 16, 2023
@MasterOdin MasterOdin mentioned this issue Jul 19, 2023
Merged
MartinThoma added a commit that referenced this issue Jul 20, 2023
@MartinThoma
DEV: Fix Github Action release.yaml
b26c4ce 
Struggling with multiline environment variables

See github/docs#21529

See #1971
@MartinThoma MartinThoma mentioned this issue Jul 20, 2023
Merged
MartinThoma pushed a commit that referenced this issue Jul 20, 2023
@MasterOdin
DEV: Add body to created GitHub release (#1985)
6df64af 
PR fixes that new GitHub releases were lacking a body, where this was due to the fact that we were not outputting `tag_body` to `$GITHUB_ENV` so that it wasn't available in follow-up steps. However, because the body is a multiline string, we've got to wrap it in special syntax to get it to work (see [docs](https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#example-of-a-multiline-string) for example).

See https://github.com/py-pdf/pypdf/actions/runs/5601580443/jobs/10245662760?pr=1985 as an example test run that shows it working in a test workflow.

Closes #1971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinThoma MartinThoma

Labels
Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEV: Add body to created GitHub release py-pdf/pypdf
1 participant
@MartinThoma