test coverage

py-pdf · Feb 28, 2024 · f23f01e · f23f01e
1 parent c8ba914
commit f23f01e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/pypdf/_writer.py b/pypdf/_writer.py
@@ -970,7 +970,10 @@ def reattach_fields(
             indirect = isinstance(ano, IndirectObject)
             ano = cast(DictionaryObject, ano.get_object())
             if ano.get("/Subtype", "") == "/Widget" and "/FT" in ano:
-                if ano.indirect_reference in fields:
+                if (
+                    "indirect_reference" in ano.__dict__
+                    and ano.indirect_reference in fields
+                ):
                     continue
                 if not indirect:
                     annots[idx] = self._add_object(ano)

diff --git a/tests/test_writer.py b/tests/test_writer.py
@@ -1999,3 +1999,15 @@ def test_reattach_fields():
     assert len(writer.reattach_fields()) == 7
     writer.reattach_fields()
     assert len(writer._root_object["/AcroForm"]["/Fields"]) == 15
+
+    writer = PdfWriter()
+    for p in reader.pages:
+        writer.add_page(p)
+    ano = writer.pages[0]["/Annots"][0].get_object()
+    del ano.indirect_reference
+    writer.pages[0]["/Annots"][0] = ano
+    assert isinstance(writer.pages[0]["/Annots"][0], DictionaryObject)
+    assert len(writer.reattach_fields(writer.pages[0])) == 6
+    assert isinstance(writer.pages[0]["/Annots"][0], IndirectObject)
+    del writer.pages[1]["/Annots"]
+    assert len(writer.reattach_fields(writer.pages[1])) == 0