decodeStreamData -> decode_stream_data

py-pdf · Jun 11, 2022 · e983e22 · e983e22
1 parent 1584094
commit e983e22
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/PyPDF2/filters.py b/PyPDF2/filters.py
@@ -89,8 +89,6 @@ def decode(
         if "decodeParms" in kwargs:
             deprecate_with_replacement("decodeParms", "parameters", "4.0.0")
             parameters = kwargs["decodeParms"]
-        if parameters is None:
-            raise ValueError("Missing decode parameters")
         str_data = decompress(data)
         predictor = 1
 
@@ -190,8 +188,6 @@ def decode(
         if "decodeParms" in kwargs:
             deprecate_with_replacement("decodeParms", "parameters", "4.0.0")
             parameters = kwargs["decodeParms"]
-        if parameters is None:
-            raise ValueError("Missing decode parameters")
         retval = ""
         hex_pair = ""
         index = 0
@@ -312,8 +308,6 @@ def decode(
         if "decodeParms" in kwargs:
             deprecate_with_replacement("decodeParms", "parameters", "4.0.0")
             parameters = kwargs["decodeParms"]
-        if parameters is None:
-            raise ValueError("Missing decode parameters")
         return LZWDecode.Decoder(data).decode()
 
 
@@ -329,8 +323,6 @@ def decode(
         if "decodeParms" in kwargs:
             deprecate_with_replacement("decodeParms", "parameters", "4.0.0")
             parameters = kwargs["decodeParms"]
-        if parameters is None:
-            raise ValueError("Missing decode parameters")
         if isinstance(data, str):
             data = data.encode("ascii")
         group_index = b = 0
@@ -364,8 +356,6 @@ def decode(
         if "decodeParms" in kwargs:
             deprecate_with_replacement("decodeParms", "parameters", "4.0.0")
             parameters = kwargs["decodeParms"]
-        if parameters is None:
-            raise ValueError("Missing decode parameters")
         return data
 
 
@@ -379,8 +369,6 @@ def decode(
         if "decodeParms" in kwargs:
             deprecate_with_replacement("decodeParms", "parameters", "4.0.0")
             parameters = kwargs["decodeParms"]
-        if parameters is None:
-            raise ValueError("Missing decode parameters")
         return data
 
 
@@ -446,8 +434,6 @@ def decode(
         if "decodeParms" in kwargs:
             deprecate_with_replacement("decodeParms", "parameters", "4.0.0")
             parameters = kwargs["decodeParms"]
-        if parameters is None:
-            raise ValueError("Missing decode parameters")
         parms = CCITTFaxDecode._get_parameters(parameters, height)
 
         img_size = len(data)
@@ -498,7 +484,7 @@ def decode(
         return tiff_header + data
 
 
-def decodeStreamData(stream: Any) -> Union[str, bytes]:  # utils.StreamObject
+def decode_stream_data(stream: Any) -> Union[str, bytes]:  # utils.StreamObject
     filters = stream.get(SA.FILTER, ())
 
     if len(filters) and not isinstance(filters[0], NameObject):
@@ -537,6 +523,11 @@ def decodeStreamData(stream: Any) -> Union[str, bytes]:  # utils.StreamObject
     return data
 
 
+def decodeStreamData(stream: Any) -> Union[str, bytes]:
+    deprecate_with_replacement("decodeStreamData", "decode_stream_data", "4.0.0")
+    return decode_stream_data(stream)
+
+
 def _xobj_to_image(x_object_obj: Dict[str, Any]) -> Tuple[Optional[str], bytes]:
     """
     Users need to have the pillow package installed.

diff --git a/PyPDF2/generic.py b/PyPDF2/generic.py
@@ -1086,7 +1086,7 @@ def decodedSelf(self, value: DecodedStreamObject) -> None:  # pragma: no cover
         self.decoded_self = value
 
     def get_data(self) -> Union[None, str, bytes]:
-        from .filters import decodeStreamData
+        from .filters import decode_stream_data
 
         if self.decoded_self is not None:
             # cached version of decoded object
@@ -1095,7 +1095,7 @@ def get_data(self) -> Union[None, str, bytes]:
             # create decoded object
             decoded = DecodedStreamObject()
 
-            decoded._data = decodeStreamData(self)
+            decoded._data = decode_stream_data(self)
             for key, value in list(self.items()):
                 if key not in (SA.LENGTH, SA.FILTER, SA.DECODE_PARMS):
                     decoded[key] = value