ROB: XYZ destination to cope with missing left and top param

closes #2236
py-pdf · Oct 3, 2023 · 73a3134 · 73a3134
1 parent 30db3ef
commit 73a3134
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/pypdf/generic/_data_structures.py b/pypdf/generic/_data_structures.py
@@ -1490,6 +1490,10 @@ def __init__(
         if len(args) == 0:
             pass
         elif typ == "/XYZ":
+            if len(args) < 1:  # left is missing : should never occur
+                args.append(NumberObject(0.0))
+            if len(args) < 2:  # top is missing
+                args.append(NumberObject(0.0))
             if len(args) < 3:  # zoom is missing
                 args.append(NumberObject(0.0))
             (

diff --git a/tests/test_reader.py b/tests/test_reader.py
@@ -1454,3 +1454,12 @@ def test_issue_140():
     b = get_data_from_url(url, name=name)
     reader = PdfReader(BytesIO(b))
     assert len(reader.pages) == 54
+
+
+@pytest.mark.enable_socket()
+def test_xyz_with_missing_param():
+    """Cf #2236"""
+    url = "https://github.com/py-pdf/pypdf/files/12795356/tt1.pdf"
+    name = "issue2236.pdf"
+    reader = PdfReader(BytesIO(get_data_from_url(url, name=name)))
+    reader.outline