Fixed CreationDate of PDFs generated, that was broken - close #451 (#452

)
py-pdf · Jun 8, 2022 · b5df110 · b5df110
1 parent d2fa052
commit b5df110
Show file tree

Hide file tree

Showing 311 changed files with 30 additions and 28 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,14 +23,15 @@ This can also be enabled programmatically with `warnings.simplefilter('default',
   and [`AnnotationFlags`](https://pyfpdf.github.io/fpdf2/fpdf/enums.html#fpdf.enums.AnnotationFlag)
   onto [text_annotation()](https://pyfpdf.github.io/fpdf2/fpdf/fpdf.html#fpdf.fpdf.FPDF.text_annotation)
 - allowing correctly parsing of SVG files with CSS styling (`style="..."` attribute), thanks to @RedShy
-- [`FPDF.star`](https://pyfpdf.github.io/fpdf2/Shapes.html#regular-star): new method added to draw regular stars, thanks to @digidigital and @RedShy
-- [`FPDF.ink_annotation`](https://pyfpdf.github.io/fpdf2/Annotations.html#ink-annotations): new method added to add path annotations
+- [`FPDF.star()`](https://pyfpdf.github.io/fpdf2/Shapes.html#regular-star): new method added to draw regular stars, thanks to @digidigital and @RedShy
+- [`FPDF.ink_annotation()`](https://pyfpdf.github.io/fpdf2/Annotations.html#ink-annotations): new method added to add path annotations
 - allowing embedding of indexed PNG images without converting them to RGB colorspace, thanks to @RedShy
 - allowing to change appearance of [highlight annotations](https://pyfpdf.github.io/fpdf2/fpdf/fpdf.html#fpdf.fpdf.FPDF.highlight) by specifying a [`TextMarkupType`](https://pyfpdf.github.io/fpdf2/fpdf/enums.html#fpdf.enums.TextMarkupType)
 - documentation on how to control objects transparency: [link to docs](https://pyfpdf.github.io/fpdf2/Transparency.html)
 - documentation on how to create tables and charts using [pandas](https://pandas.pydata.org/) DataFrames: [link to docs](https://pyfpdf.github.io/fpdf2/Maths.html), thanks to @iwayankurniawan
 ### Fixed
-- support for `"x"` & `"y"` attributes in SVG `<use>` tags
+- support for `"x"` & `"y"` attributes in SVG `<use>` tags - _cf._ [#446](https://github.com/PyFPDF/fpdf2/issues/446)
+- `CreationDate` of PDFs generated, that was broken - _cf._ [#451](https://github.com/PyFPDF/fpdf2/issues/451)
 
 ## [2.5.4] - 2022-05-05
 ### Added

diff --git a/fpdf/drawing.py b/fpdf/drawing.py
@@ -2940,7 +2940,7 @@ def render(self, gsd_registry, style, last_item, initial_point):
             a tuple of `(str, new_last_item)`, where `new_last_item` is whatever the old
             last_item was.
         """
-        # pylint: disable=unused-argument,no-self-use
+        # pylint: disable=unused-argument
         if style.auto_close:
             return "h", last_item, initial_point
 
@@ -3004,7 +3004,7 @@ def render(self, gsd_registry, style, last_item, initial_point):
             a tuple of `(str, new_last_item)`, where `new_last_item` is whatever the old
             last_item was.
         """
-        # pylint: disable=unused-argument,no-self-use
+        # pylint: disable=unused-argument
         return "h", Move(initial_point), initial_point
 
     @force_nodocument

diff --git a/fpdf/fpdf.py b/fpdf/fpdf.py
@@ -26,7 +26,7 @@
 from collections import OrderedDict, defaultdict
 from collections.abc import Sequence
 from contextlib import contextmanager
-from datetime import datetime
+from datetime import datetime, timezone
 from functools import wraps
 from math import isclose
 from os.path import splitext
@@ -434,15 +434,15 @@ def __init__(
         self.viewer_preferences = None
         self.compress = True  # Enable compression by default
         self.pdf_version = "1.3"  # Set default PDF version No.
+        self.creation_date = True
 
         self._current_draw_context = None
         self._drawing_graphics_state_registry = drawing.GraphicsStateDictRegistry()
         self._graphics_state_obj_refs = OrderedDict()
 
         self.record_text_quad_points = False
-        self.text_quad_points = defaultdict(
-            list
-        )  # page number -> array of 8 × n numbers
+        # page number -> array of 8 × n numbers:
+        self.text_quad_points = defaultdict(list)
 
     def _set_min_pdf_version(self, version):
         self.pdf_version = max(self.pdf_version, version)
@@ -681,7 +681,7 @@ def set_producer(self, producer):
 
     def set_creation_date(self, date=None):
         """Sets Creation of Date time, or current time if None given."""
-        self.creation_date = datetime.now() if date is None else date
+        self.creation_date = date
 
     def set_xmp_metadata(self, xmp_metadata):
         if "<?xpacket" in xmp_metadata[:50]:
@@ -3219,7 +3219,7 @@ def image(
             # disabling bandit rule as we just build a cache key, this is secure
             name, img = hashlib.md5(bytes).hexdigest(), name  # nosec B303 B324
         elif isinstance(name, io.BytesIO):
-            bytes = name.getvalue()
+            bytes = name.getvalue().strip()
             if _is_svg(bytes):
                 return self._vector_image(name, x, y, w, h, link, title, alt_text)
             # disabling bandit rule as we just build a cache key, this is secure
@@ -4151,17 +4151,18 @@ def _putinfo(self):
             "/Producer": enclose_in_parens(getattr(self, "producer", None)),
         }
 
-        if hasattr(self, "creation_date"):
+        if self.creation_date is True:
+            # => no date has been specified, we use the current time by default:
+            self.creation_date = datetime.now(timezone.utc)
+        if self.creation_date:
             try:
-                creation_date = self.creation_date
-                date_string = f"{creation_date:%Y%m%d%H%M%S}"
+                info_d["/CreationDate"] = enclose_in_parens(
+                    f"D:{self.creation_date:%Y%m%d%H%M%SZ%H'%M'}"
+                )
             except Exception as error:
                 raise FPDFException(
-                    f"Could not format date: {creation_date}"
+                    f"Could not format date: {self.creation_date}"
                 ) from error
-        else:
-            date_string = f"{datetime.now():%Y%m%d%H%M%S}"
-        info_d["/CreationDate"] = enclose_in_parens(f"D:{date_string}")
 
         self._out(pdf_dict(info_d, open_dict="", close_dict="", has_empty_fields=True))
 

diff --git a/fpdf/html.py b/fpdf/html.py
@@ -697,7 +697,6 @@ def put_link(self, txt):
         self.set_style("u", False)
         self.set_text_color(*self.font_color)
 
-    # pylint: disable=no-self-use
     def render_toc(self, pdf, outline):
         "This method can be overriden by subclasses to customize the Table of Contents style."
         pdf.ln()

diff --git a/test/add_page_duration.pdf b/test/add_page_duration.pdf
diff --git a/test/add_page_format.pdf b/test/add_page_format.pdf
diff --git a/test/alias_nb_pages.pdf b/test/alias_nb_pages.pdf
diff --git a/test/barcodes/barcodes_code39.pdf b/test/barcodes/barcodes_code39.pdf
diff --git a/test/barcodes/barcodes_interleaved2of5.pdf b/test/barcodes/barcodes_interleaved2of5.pdf
diff --git a/test/break_or_add_page.pdf b/test/break_or_add_page.pdf
diff --git a/test/break_or_add_page_draw_fill.pdf b/test/break_or_add_page_draw_fill.pdf
diff --git a/test/conftest.py b/test/conftest.py
@@ -66,7 +66,10 @@ def assert_pdf_equal(actual, expected, tmp_path, generate=False):
         actual_pdf = actual.pdf
     else:
         actual_pdf = actual
-    actual_pdf.set_creation_date(EPOCH)
+    if (
+        actual_pdf.creation_date is True
+    ):  # default value, meaning we are not testing .creation_date behaviour:
+        actual_pdf.set_creation_date(EPOCH)
     if generate:
         assert isinstance(expected, pathlib.Path), (
             "When passing `True` to `generate`"

diff --git a/test/drawing/generated_pdf/blending_images.pdf b/test/drawing/generated_pdf/blending_images.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_color_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_color_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_color_burn_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_color_burn_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_color_dodge_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_color_dodge_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_darken_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_darken_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_difference_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_difference_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_exclusion_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_exclusion_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_hard_light_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_hard_light_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_hue_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_hue_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_lighten_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_lighten_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_luminosity_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_luminosity_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_multiply_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_multiply_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_normal_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_normal_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_overlay_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_overlay_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_saturation_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_saturation_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_screen_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_screen_.pdf
diff --git a/test/drawing/generated_pdf/test_blend_modes_blend_mode_soft_light_.pdf b/test/drawing/generated_pdf/test_blend_modes_blend_mode_soft_light_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_0_stroke_width_.pdf b/test/drawing/generated_pdf/test_individual_attribute_0_stroke_width_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_2_stroke_width_.pdf b/test/drawing/generated_pdf/test_individual_attribute_2_stroke_width_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_50-50_stroke_dash_pattern_.pdf b/test/drawing/generated_pdf/test_individual_attribute_50-50_stroke_dash_pattern_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_RGBA_4_fill_color_.pdf b/test/drawing/generated_pdf/test_individual_attribute_RGBA_4_fill_color_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_RGBA_4_stroke_color_.pdf b/test/drawing/generated_pdf/test_individual_attribute_RGBA_4_stroke_color_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_RGBA_8_fill_color_.pdf b/test/drawing/generated_pdf/test_individual_attribute_RGBA_8_fill_color_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_RGBA_8_stroke_color_.pdf b/test/drawing/generated_pdf/test_individual_attribute_RGBA_8_stroke_color_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_RGB_3_fill_color_.pdf b/test/drawing/generated_pdf/test_individual_attribute_RGB_3_fill_color_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_RGB_3_stroke_color_.pdf b/test/drawing/generated_pdf/test_individual_attribute_RGB_3_stroke_color_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_RGB_6_fill_color_.pdf b/test/drawing/generated_pdf/test_individual_attribute_RGB_6_fill_color_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_RGB_6_stroke_color_.pdf b/test/drawing/generated_pdf/test_individual_attribute_RGB_6_stroke_color_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_auto_close_.pdf b/test/drawing/generated_pdf/test_individual_attribute_auto_close_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_bevel_stroke_join_.pdf b/test/drawing/generated_pdf/test_individual_attribute_bevel_stroke_join_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_butt_stroke_cap_.pdf b/test/drawing/generated_pdf/test_individual_attribute_butt_stroke_cap_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_complex_stroke_dash_pattern_.pdf b/test/drawing/generated_pdf/test_individual_attribute_complex_stroke_dash_pattern_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_half_fill_opacity_.pdf b/test/drawing/generated_pdf/test_individual_attribute_half_fill_opacity_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_half_stroke_opacity_.pdf b/test/drawing/generated_pdf/test_individual_attribute_half_stroke_opacity_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_intersection_rule_.pdf b/test/drawing/generated_pdf/test_individual_attribute_intersection_rule_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_miter_stroke_join_.pdf b/test/drawing/generated_pdf/test_individual_attribute_miter_stroke_join_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_no_fill_color_.pdf b/test/drawing/generated_pdf/test_individual_attribute_no_fill_color_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_no_fill_opacity_.pdf b/test/drawing/generated_pdf/test_individual_attribute_no_fill_opacity_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_no_stroke_color_.pdf b/test/drawing/generated_pdf/test_individual_attribute_no_stroke_color_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_no_stroke_opacity_.pdf b/test/drawing/generated_pdf/test_individual_attribute_no_stroke_opacity_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_no_stroke_width_.pdf b/test/drawing/generated_pdf/test_individual_attribute_no_stroke_width_.pdf
diff --git a/test/drawing/generated_pdf/test_individual_attribute_square_stroke_cap_.pdf b/test/drawing/generated_pdf/test_individual_attribute_square_stroke_cap_.pdf
diff --git a/test/drawing/generated_pdf/test_inheriting_document_properties.pdf b/test/drawing/generated_pdf/test_inheriting_document_properties.pdf
diff --git a/test/drawing/generated_pdf/test_stroke_dash_phase.pdf b/test/drawing/generated_pdf/test_stroke_dash_phase.pdf
diff --git a/test/drawing/generated_pdf/test_stroke_miter_limit.pdf b/test/drawing/generated_pdf/test_stroke_miter_limit.pdf
diff --git a/test/drawing/parameters.py b/test/drawing/parameters.py
@@ -1,4 +1,4 @@
-# pylint: disable=redefined-outer-name, no-self-use, protected-access
+# pylint: disable=redefined-outer-name, protected-access
 import pytest
 
 from decimal import Decimal

diff --git a/test/drawing/test_drawing.py b/test/drawing/test_drawing.py
@@ -1,4 +1,4 @@
-# pylint: disable=redefined-outer-name, no-self-use, protected-access, unused-argument
+# pylint: disable=redefined-outer-name, protected-access, unused-argument
 
 import copy
 import io

diff --git a/test/end_to_end_legacy/charmap/charmap_first_999_chars-DejaVuSans.pdf b/test/end_to_end_legacy/charmap/charmap_first_999_chars-DejaVuSans.pdf
diff --git a/test/end_to_end_legacy/charmap/charmap_first_999_chars-DroidSansFallback.pdf b/test/end_to_end_legacy/charmap/charmap_first_999_chars-DroidSansFallback.pdf
diff --git a/test/end_to_end_legacy/charmap/charmap_first_999_chars-Roboto-Regular.pdf b/test/end_to_end_legacy/charmap/charmap_first_999_chars-Roboto-Regular.pdf
diff --git a/test/end_to_end_legacy/charmap/charmap_first_999_chars-cmss12.pdf b/test/end_to_end_legacy/charmap/charmap_first_999_chars-cmss12.pdf
diff --git a/test/errors/repeated_calls_to_output.pdf b/test/errors/repeated_calls_to_output.pdf
diff --git a/test/fonts/add_font_unicode.pdf b/test/fonts/add_font_unicode.pdf
diff --git a/test/fonts/fonts_emoji_glyph.pdf b/test/fonts/fonts_emoji_glyph.pdf
diff --git a/test/fonts/fonts_issue_66.pdf b/test/fonts/fonts_issue_66.pdf
diff --git a/test/fonts/fonts_remap_nb.pdf b/test/fonts/fonts_remap_nb.pdf
diff --git a/test/fonts/fonts_set_builtin_font.pdf b/test/fonts/fonts_set_builtin_font.pdf
diff --git a/test/fonts/fonts_two_mappings.pdf b/test/fonts/fonts_two_mappings.pdf
diff --git a/test/fonts/render_en_dash.pdf b/test/fonts/render_en_dash.pdf
diff --git a/test/fonts/thai_text.pdf b/test/fonts/thai_text.pdf
diff --git a/test/goto_action.pdf b/test/goto_action.pdf
diff --git a/test/goto_next_page_chained.pdf b/test/goto_next_page_chained.pdf
diff --git a/test/goto_remote_action.pdf b/test/goto_remote_action.pdf
diff --git a/test/graphics_context.pdf b/test/graphics_context.pdf
diff --git a/test/highlighted.pdf b/test/highlighted.pdf
diff --git a/test/highlighted_over_page_break.pdf b/test/highlighted_over_page_break.pdf
diff --git a/test/html/html_bold_italic_underline.pdf b/test/html/html_bold_italic_underline.pdf
diff --git a/test/html/html_custom_heading_sizes.pdf b/test/html/html_custom_heading_sizes.pdf
diff --git a/test/html/html_features.pdf b/test/html/html_features.pdf
diff --git a/test/html/html_font_color_name.pdf b/test/html/html_font_color_name.pdf
diff --git a/test/html/html_heading_hebrew.pdf b/test/html/html_heading_hebrew.pdf
diff --git a/test/html/html_headings_line_height.pdf b/test/html/html_headings_line_height.pdf
diff --git a/test/html/html_images.pdf b/test/html/html_images.pdf
diff --git a/test/html/html_justify_paragraph.pdf b/test/html/html_justify_paragraph.pdf
diff --git a/test/html/html_simple_table.pdf b/test/html/html_simple_table.pdf
diff --git a/test/html/html_table_line_separators.pdf b/test/html/html_table_line_separators.pdf
diff --git a/test/html/html_table_line_separators_issue_137.pdf b/test/html/html_table_line_separators_issue_137.pdf
diff --git a/test/html/html_table_with_border.pdf b/test/html/html_table_with_border.pdf
diff --git a/test/html/html_table_with_empty_cell_contents.pdf b/test/html/html_table_with_empty_cell_contents.pdf
diff --git a/test/html/issue_156.pdf b/test/html/issue_156.pdf
diff --git a/test/html/test_customize_ul.pdf b/test/html/test_customize_ul.pdf
diff --git a/test/html/test_img_inside_html_table.pdf b/test/html/test_img_inside_html_table.pdf
diff --git a/test/html/test_img_inside_html_table_centered.pdf b/test/html/test_img_inside_html_table_centered.pdf
diff --git a/test/html/test_img_inside_html_table_centered_with_align.pdf b/test/html/test_img_inside_html_table_centered_with_align.pdf
diff --git a/test/html/test_img_inside_html_table_centered_with_caption.pdf b/test/html/test_img_inside_html_table_centered_with_caption.pdf
diff --git a/test/html/test_img_inside_html_table_without_explicit_dimensions.pdf b/test/html/test_img_inside_html_table_without_explicit_dimensions.pdf
diff --git a/test/image/alt_text/alt_text_and_title.pdf b/test/image/alt_text/alt_text_and_title.pdf
diff --git a/test/image/alt_text/test_alt_text_on_two_pages.pdf b/test/image/alt_text/test_alt_text_on_two_pages.pdf
diff --git a/test/image/elliptic_clip.pdf b/test/image/elliptic_clip.pdf
diff --git a/test/image/full_height_image.pdf b/test/image/full_height_image.pdf
diff --git a/test/image/full_width_image.pdf b/test/image/full_width_image.pdf
diff --git a/test/image/image_png_url.pdf b/test/image/image_png_url.pdf
diff --git a/test/image/image_types/image_types_insert_bmp.pdf b/test/image/image_types/image_types_insert_bmp.pdf
diff --git a/test/image/image_types/image_types_insert_gif.pdf b/test/image/image_types/image_types_insert_gif.pdf
diff --git a/test/image/image_types/image_types_insert_jpg.pdf b/test/image/image_types/image_types_insert_jpg.pdf
diff --git a/test/image/image_types/image_types_insert_jpg_flatedecode.pdf b/test/image/image_types/image_types_insert_jpg_flatedecode.pdf
diff --git a/test/image/image_types/image_types_insert_jpg_flatedecode_windows.pdf b/test/image/image_types/image_types_insert_jpg_flatedecode_windows.pdf
diff --git a/test/image/image_types/image_types_insert_jpg_jpxdecode.pdf b/test/image/image_types/image_types_insert_jpg_jpxdecode.pdf
diff --git a/test/image/image_types/image_types_insert_jpg_windows.pdf b/test/image/image_types/image_types_insert_jpg_windows.pdf
diff --git a/test/image/image_types/image_types_insert_png.pdf b/test/image/image_types/image_types_insert_png.pdf
diff --git a/test/image/image_types/image_types_insert_png_alpha.pdf b/test/image/image_types/image_types_insert_png_alpha.pdf
diff --git a/test/image/image_types/image_types_insert_png_alpha_dctdecode.pdf b/test/image/image_types/image_types_insert_png_alpha_dctdecode.pdf
diff --git a/test/image/image_types/image_types_insert_png_alpha_dctdecode_windows.pdf b/test/image/image_types/image_types_insert_png_alpha_dctdecode_windows.pdf
diff --git a/test/image/image_types/image_types_insert_png_disallow_transparency.pdf b/test/image/image_types/image_types_insert_png_disallow_transparency.pdf
diff --git a/test/image/image_types/insert_pillow_issue_139.pdf b/test/image/image_types/insert_pillow_issue_139.pdf
diff --git a/test/image/load_base64_data.pdf b/test/image/load_base64_data.pdf
diff --git a/test/image/oversized_images_downscale_biggest_1st.pdf b/test/image/oversized_images_downscale_biggest_1st.pdf
diff --git a/test/image/oversized_images_downscale_biggest_2nd.pdf b/test/image/oversized_images_downscale_biggest_2nd.pdf
diff --git a/test/image/oversized_images_downscale_simple.pdf b/test/image/oversized_images_downscale_simple.pdf
diff --git a/test/image/oversized_images_downscale_twice.pdf b/test/image/oversized_images_downscale_twice.pdf
diff --git a/test/image/png_images/image_png_insert_png_files.pdf b/test/image/png_images/image_png_insert_png_files.pdf
diff --git a/test/image/png_indexed/image_png_indexed_no_transparency.pdf b/test/image/png_indexed/image_png_indexed_no_transparency.pdf
diff --git a/test/image/png_indexed/image_png_indexed_transparency.pdf b/test/image/png_indexed/image_png_indexed_transparency.pdf
diff --git a/test/image/rect_clip.pdf b/test/image/rect_clip.pdf
diff --git a/test/image/round_clip.pdf b/test/image/round_clip.pdf
diff --git a/test/image/svg_image.pdf b/test/image/svg_image.pdf
diff --git a/test/image/svg_image_fixed_dimensions.pdf b/test/image/svg_image_fixed_dimensions.pdf
diff --git a/test/image/svg_image_from_bytesio.pdf b/test/image/svg_image_from_bytesio.pdf
diff --git a/test/image/svg_image_style_inherited_from_fpdf.pdf b/test/image/svg_image_style_inherited_from_fpdf.pdf
diff --git a/test/image/svg_image_with_custom_size.pdf b/test/image/svg_image_with_custom_size.pdf
diff --git a/test/image/svg_image_with_custom_width.pdf b/test/image/svg_image_with_custom_width.pdf
diff --git a/test/image/test_url_images.py b/test/image/test_url_images.py
@@ -14,7 +14,6 @@
 )
 def test_png_url(tmp_path):
     pdf = fpdf.FPDF()
-    pdf.compress = False
     pdf.add_page()
     png = "https://upload.wikimedia.org/wikipedia/commons/7/70/Example.png"
     pdf.image(png, x=15, y=15, w=30, h=25)

diff --git a/test/infinite_loop_with_goto_action.pdf b/test/infinite_loop_with_goto_action.pdf
diff --git a/test/ink_annotation.pdf b/test/ink_annotation.pdf
diff --git a/test/launch_action.pdf b/test/launch_action.pdf
diff --git a/test/layout/set_no_margin.pdf b/test/layout/set_no_margin.pdf
diff --git a/test/layout/unit_cm.pdf b/test/layout/unit_cm.pdf
diff --git a/test/layout/unit_default.pdf b/test/layout/unit_default.pdf
diff --git a/test/layout/unit_float.pdf b/test/layout/unit_float.pdf
diff --git a/test/layout/unit_in.pdf b/test/layout/unit_in.pdf
diff --git a/test/layout/unit_int.pdf b/test/layout/unit_int.pdf
diff --git a/test/layout/unit_mm.pdf b/test/layout/unit_mm.pdf
diff --git a/test/layout/unit_pt.pdf b/test/layout/unit_pt.pdf
diff --git a/test/link_alt_text.pdf b/test/link_alt_text.pdf
diff --git a/test/link_border.pdf b/test/link_border.pdf
diff --git a/test/link_with_zoom_and_shift.pdf b/test/link_with_zoom_and_shift.pdf
diff --git a/test/links.pdf b/test/links.pdf
diff --git a/test/local_context_inherited_shared_props.pdf b/test/local_context_inherited_shared_props.pdf
diff --git a/test/local_context_init.pdf b/test/local_context_init.pdf
diff --git a/test/local_context_shared_props.pdf b/test/local_context_shared_props.pdf
diff --git a/test/metadata/custom_viewer_preferences.pdf b/test/metadata/custom_viewer_preferences.pdf
diff --git a/test/metadata/default_viewer_preferences.pdf b/test/metadata/default_viewer_preferences.pdf
diff --git a/test/metadata/layout-alias-continuous.pdf b/test/metadata/layout-alias-continuous.pdf
diff --git a/test/metadata/layout-alias-default.pdf b/test/metadata/layout-alias-default.pdf
diff --git a/test/metadata/layout-alias-single.pdf b/test/metadata/layout-alias-single.pdf
diff --git a/test/metadata/layout-alias-two.pdf b/test/metadata/layout-alias-two.pdf
diff --git a/test/metadata/page-layout-ONE_COLUMN.pdf b/test/metadata/page-layout-ONE_COLUMN.pdf
diff --git a/test/metadata/page-layout-SINGLE_PAGE.pdf b/test/metadata/page-layout-SINGLE_PAGE.pdf
diff --git a/test/metadata/page-layout-TWO_COLUMN_LEFT.pdf b/test/metadata/page-layout-TWO_COLUMN_LEFT.pdf
diff --git a/test/metadata/page-layout-TWO_COLUMN_RIGHT.pdf b/test/metadata/page-layout-TWO_COLUMN_RIGHT.pdf
diff --git a/test/metadata/page-layout-TWO_PAGE_LEFT.pdf b/test/metadata/page-layout-TWO_PAGE_LEFT.pdf
diff --git a/test/metadata/page-layout-TWO_PAGE_RIGHT.pdf b/test/metadata/page-layout-TWO_PAGE_RIGHT.pdf
diff --git a/test/metadata/page-mode-FULL_SCREEN.pdf b/test/metadata/page-mode-FULL_SCREEN.pdf
diff --git a/test/metadata/page-mode-USE_ATTACHMENTS.pdf b/test/metadata/page-mode-USE_ATTACHMENTS.pdf
diff --git a/test/metadata/page-mode-USE_NONE.pdf b/test/metadata/page-mode-USE_NONE.pdf
diff --git a/test/metadata/page-mode-USE_OC.pdf b/test/metadata/page-mode-USE_OC.pdf
diff --git a/test/metadata/page-mode-USE_OUTLINES.pdf b/test/metadata/page-mode-USE_OUTLINES.pdf
diff --git a/test/metadata/page-mode-USE_THUMBS.pdf b/test/metadata/page-mode-USE_THUMBS.pdf
diff --git a/test/metadata/put_info_all.pdf b/test/metadata/put_info_all.pdf
diff --git a/test/metadata/put_info_some.pdf b/test/metadata/put_info_some.pdf
diff --git a/test/metadata/setting_old_date.pdf b/test/metadata/setting_old_date.pdf
diff --git a/test/metadata/xmp_metadata.pdf b/test/metadata/xmp_metadata.pdf
diff --git a/test/metadata/zoom-default.pdf b/test/metadata/zoom-default.pdf
diff --git a/test/metadata/zoom-fullpage.pdf b/test/metadata/zoom-fullpage.pdf
diff --git a/test/metadata/zoom-fullwidth.pdf b/test/metadata/zoom-fullwidth.pdf
diff --git a/test/metadata/zoom-real.pdf b/test/metadata/zoom-real.pdf
diff --git a/test/named_actions.pdf b/test/named_actions.pdf
diff --git a/test/outline/2_pages_outline.pdf b/test/outline/2_pages_outline.pdf
diff --git a/test/outline/custom_HTML2FPDF.pdf b/test/outline/custom_HTML2FPDF.pdf
diff --git a/test/outline/html_toc.pdf b/test/outline/html_toc.pdf
diff --git a/test/outline/html_toc_2_pages.pdf b/test/outline/html_toc_2_pages.pdf
diff --git a/test/outline/html_toc_with_h1_as_2nd_heading.pdf b/test/outline/html_toc_with_h1_as_2nd_heading.pdf
diff --git a/test/outline/russian_heading.pdf b/test/outline/russian_heading.pdf
diff --git a/test/outline/self_refering_outline.pdf b/test/outline/self_refering_outline.pdf
diff --git a/test/outline/simple_outline.pdf b/test/outline/simple_outline.pdf
diff --git a/test/rotation.pdf b/test/rotation.pdf
diff --git a/test/shapes/class_arc_clockwise.pdf b/test/shapes/class_arc_clockwise.pdf
diff --git a/test/shapes/class_arc_draw_color.pdf b/test/shapes/class_arc_draw_color.pdf
diff --git a/test/shapes/class_arc_end_at_center.pdf b/test/shapes/class_arc_end_at_center.pdf
diff --git a/test/shapes/class_arc_fill_color.pdf b/test/shapes/class_arc_fill_color.pdf
diff --git a/test/shapes/class_arc_inclination.pdf b/test/shapes/class_arc_inclination.pdf
diff --git a/test/shapes/class_arc_line_width.pdf b/test/shapes/class_arc_line_width.pdf
diff --git a/test/shapes/class_arc_not_circle.pdf b/test/shapes/class_arc_not_circle.pdf
diff --git a/test/shapes/class_arc_start_from_center.pdf b/test/shapes/class_arc_start_from_center.pdf
diff --git a/test/shapes/class_arc_style.pdf b/test/shapes/class_arc_style.pdf
diff --git a/test/shapes/class_circle_draw_color.pdf b/test/shapes/class_circle_draw_color.pdf
diff --git a/test/shapes/class_circle_fill_color.pdf b/test/shapes/class_circle_fill_color.pdf
diff --git a/test/shapes/class_circle_line_width.pdf b/test/shapes/class_circle_line_width.pdf
diff --git a/test/shapes/class_circle_style.pdf b/test/shapes/class_circle_style.pdf
diff --git a/test/shapes/class_dash.pdf b/test/shapes/class_dash.pdf
diff --git a/test/shapes/class_ellipse_draw_color.pdf b/test/shapes/class_ellipse_draw_color.pdf
diff --git a/test/shapes/class_ellipse_fill_color.pdf b/test/shapes/class_ellipse_fill_color.pdf
diff --git a/test/shapes/class_ellipse_line_width.pdf b/test/shapes/class_ellipse_line_width.pdf
diff --git a/test/shapes/class_ellipse_not_circle.pdf b/test/shapes/class_ellipse_not_circle.pdf
diff --git a/test/shapes/class_ellipse_style.pdf b/test/shapes/class_ellipse_style.pdf
diff --git a/test/shapes/class_line.pdf b/test/shapes/class_line.pdf
diff --git a/test/shapes/class_rect_draw_color.pdf b/test/shapes/class_rect_draw_color.pdf
diff --git a/test/shapes/class_rect_fill_color.pdf b/test/shapes/class_rect_fill_color.pdf
diff --git a/test/shapes/class_rect_line_width.pdf b/test/shapes/class_rect_line_width.pdf
diff --git a/test/shapes/class_rect_not_square.pdf b/test/shapes/class_rect_not_square.pdf
diff --git a/test/shapes/class_rect_style.pdf b/test/shapes/class_rect_style.pdf
diff --git a/test/shapes/class_solid_arc_clockwise.pdf b/test/shapes/class_solid_arc_clockwise.pdf
diff --git a/test/shapes/class_solid_arc_draw_color.pdf b/test/shapes/class_solid_arc_draw_color.pdf
diff --git a/test/shapes/class_solid_arc_fill_color.pdf b/test/shapes/class_solid_arc_fill_color.pdf
diff --git a/test/shapes/class_solid_arc_inclination.pdf b/test/shapes/class_solid_arc_inclination.pdf
diff --git a/test/shapes/class_solid_arc_line_width.pdf b/test/shapes/class_solid_arc_line_width.pdf
diff --git a/test/shapes/class_solid_arc_not_circle.pdf b/test/shapes/class_solid_arc_not_circle.pdf
diff --git a/test/shapes/class_solid_arc_style.pdf b/test/shapes/class_solid_arc_style.pdf
diff --git a/test/shapes/dash_pattern.pdf b/test/shapes/dash_pattern.pdf
diff --git a/test/shapes/filled_polygon.pdf b/test/shapes/filled_polygon.pdf
diff --git a/test/shapes/regular_polygon.pdf b/test/shapes/regular_polygon.pdf
diff --git a/test/shapes/regular_star.pdf b/test/shapes/regular_star.pdf
diff --git a/test/svg/generated_pdf/Ghostscript_colorcircle.pdf b/test/svg/generated_pdf/Ghostscript_colorcircle.pdf
diff --git a/test/svg/generated_pdf/Ghostscript_escher.pdf b/test/svg/generated_pdf/Ghostscript_escher.pdf
diff --git a/test/svg/generated_pdf/SVG_logo.pdf b/test/svg/generated_pdf/SVG_logo.pdf
diff --git a/test/svg/generated_pdf/SVG_logo_notransparency.pdf b/test/svg/generated_pdf/SVG_logo_notransparency.pdf
diff --git a/test/svg/generated_pdf/arcs01-offset.pdf b/test/svg/generated_pdf/arcs01-offset.pdf
diff --git a/test/svg/generated_pdf/arcs01.pdf b/test/svg/generated_pdf/arcs01.pdf
diff --git a/test/svg/generated_pdf/arcs02.pdf b/test/svg/generated_pdf/arcs02.pdf
diff --git a/test/svg/generated_pdf/circle01.pdf b/test/svg/generated_pdf/circle01.pdf
diff --git a/test/svg/generated_pdf/cubic01.pdf b/test/svg/generated_pdf/cubic01.pdf
diff --git a/test/svg/generated_pdf/cubic02.pdf b/test/svg/generated_pdf/cubic02.pdf
diff --git a/test/svg/generated_pdf/ellipse01.pdf b/test/svg/generated_pdf/ellipse01.pdf
diff --git a/test/svg/generated_pdf/issue_358.pdf b/test/svg/generated_pdf/issue_358.pdf
diff --git a/test/svg/generated_pdf/issue_358b.pdf b/test/svg/generated_pdf/issue_358b.pdf
diff --git a/test/svg/generated_pdf/line01.pdf b/test/svg/generated_pdf/line01.pdf
diff --git a/test/svg/generated_pdf/polygon01.pdf b/test/svg/generated_pdf/polygon01.pdf
diff --git a/test/svg/generated_pdf/polyline01.pdf b/test/svg/generated_pdf/polyline01.pdf
diff --git a/test/svg/generated_pdf/quad01.pdf b/test/svg/generated_pdf/quad01.pdf
diff --git a/test/svg/generated_pdf/rect01.pdf b/test/svg/generated_pdf/rect01.pdf
diff --git a/test/svg/generated_pdf/rect02.pdf b/test/svg/generated_pdf/rect02.pdf
diff --git a/test/svg/generated_pdf/search.pdf b/test/svg/generated_pdf/search.pdf
diff --git a/test/svg/generated_pdf/simple_rect.pdf b/test/svg/generated_pdf/simple_rect.pdf
diff --git a/test/svg/generated_pdf/transforms/matrix.pdf b/test/svg/generated_pdf/transforms/matrix.pdf
diff --git a/test/svg/generated_pdf/transforms/multi.pdf b/test/svg/generated_pdf/transforms/multi.pdf
diff --git a/test/svg/generated_pdf/transforms/rotate.pdf b/test/svg/generated_pdf/transforms/rotate.pdf
diff --git a/test/svg/generated_pdf/transforms/scale.pdf b/test/svg/generated_pdf/transforms/scale.pdf
diff --git a/test/svg/generated_pdf/transforms/skew.pdf b/test/svg/generated_pdf/transforms/skew.pdf
diff --git a/test/svg/generated_pdf/transforms/translate.pdf b/test/svg/generated_pdf/transforms/translate.pdf
diff --git a/test/svg/generated_pdf/triangle01.pdf b/test/svg/generated_pdf/triangle01.pdf
diff --git a/test/svg/generated_pdf/use-xlink-href.pdf b/test/svg/generated_pdf/use-xlink-href.pdf
diff --git a/test/svg/generated_pdf/viewbox.pdf b/test/svg/generated_pdf/viewbox.pdf
diff --git a/test/svg/parameters.py b/test/svg/parameters.py
@@ -1,4 +1,4 @@
-# pylint: disable=redefined-outer-name, no-self-use, protected-access
+# pylint: disable=redefined-outer-name, protected-access, unnecessary-lambda-assignment
 import pytest
 
 from contextlib import contextmanager

diff --git a/test/svg/svg_sources/use-xlink-href.svg b/test/svg/svg_sources/use-xlink-href.svg
diff --git a/test/svg/test_svg.py b/test/svg/test_svg.py
@@ -1,4 +1,4 @@
-# pylint: disable=redefined-outer-name, no-self-use, protected-access
+# pylint: disable=redefined-outer-name, protected-access
 import io
 from pathlib import Path
 

diff --git a/test/template/flextemplate_elements.pdf b/test/template/flextemplate_elements.pdf
diff --git a/test/template/flextemplate_multipage.pdf b/test/template/flextemplate_multipage.pdf
diff --git a/test/template/flextemplate_offset.pdf b/test/template/flextemplate_offset.pdf
diff --git a/test/template/flextemplate_rotation.pdf b/test/template/flextemplate_rotation.pdf
diff --git a/test/template/template_code39.pdf b/test/template/template_code39.pdf
diff --git a/test/template/template_code39_defaultheight.pdf b/test/template/template_code39_defaultheight.pdf
diff --git a/test/template/template_justify.pdf b/test/template/template_justify.pdf
diff --git a/test/template/template_multipage.pdf b/test/template/template_multipage.pdf
diff --git a/test/template/template_nominal_csv.pdf b/test/template/template_nominal_csv.pdf
diff --git a/test/template/template_nominal_hardcoded.pdf b/test/template/template_nominal_hardcoded.pdf
diff --git a/test/template/template_qrcode.pdf b/test/template/template_qrcode.pdf
diff --git a/test/template/template_rect_background.pdf b/test/template/template_rect_background.pdf
diff --git a/test/template/template_textstyles.pdf b/test/template/template_textstyles.pdf
diff --git a/test/text/cell_centering.pdf b/test/text/cell_centering.pdf
diff --git a/test/text/cell_ln_newpos.pdf b/test/text/cell_ln_newpos.pdf
diff --git a/test/text/cell_markdown.pdf b/test/text/cell_markdown.pdf
diff --git a/test/text/cell_markdown_bleeding.pdf b/test/text/cell_markdown_bleeding.pdf
diff --git a/test/text/cell_markdown_right_aligned.pdf b/test/text/cell_markdown_right_aligned.pdf
diff --git a/test/text/cell_markdown_with_ttf_fonts.pdf b/test/text/cell_markdown_with_ttf_fonts.pdf
diff --git a/test/text/cell_newpos.pdf b/test/text/cell_newpos.pdf
diff --git a/test/text/cell_table_unbreakable.pdf b/test/text/cell_table_unbreakable.pdf
diff --git a/test/text/cell_table_with_pagebreak.pdf b/test/text/cell_table_with_pagebreak.pdf
diff --git a/test/text/cell_without_w_nor_h.pdf b/test/text/cell_without_w_nor_h.pdf
diff --git a/test/text/clip_text_modes.pdf b/test/text/clip_text_modes.pdf
diff --git a/test/text/ln_0.pdf b/test/text/ln_0.pdf
diff --git a/test/text/ln_1.pdf b/test/text/ln_1.pdf
diff --git a/test/text/ln_positioning_and_page_breaking_for_cell.pdf b/test/text/ln_positioning_and_page_breaking_for_cell.pdf
diff --git a/test/text/ln_positioning_and_page_breaking_for_multicell.pdf b/test/text/ln_positioning_and_page_breaking_for_multicell.pdf
diff --git a/test/text/multi_cell_border_thickness.pdf b/test/text/multi_cell_border_thickness.pdf
diff --git a/test/text/multi_cell_font_leakage.pdf b/test/text/multi_cell_font_leakage.pdf
diff --git a/test/text/multi_cell_j_paragraphs.pdf b/test/text/multi_cell_j_paragraphs.pdf
diff --git a/test/text/multi_cell_ln_1.pdf b/test/text/multi_cell_ln_1.pdf
diff --git a/test/text/multi_cell_ln_3.pdf b/test/text/multi_cell_ln_3.pdf
diff --git a/test/text/multi_cell_ln_3_table.pdf b/test/text/multi_cell_ln_3_table.pdf
diff --git a/test/text/multi_cell_ln_newpos.pdf b/test/text/multi_cell_ln_newpos.pdf
diff --git a/test/text/multi_cell_markdown.pdf b/test/text/multi_cell_markdown.pdf
diff --git a/test/text/multi_cell_markdown_justified.pdf b/test/text/multi_cell_markdown_justified.pdf
diff --git a/test/text/multi_cell_markdown_with_fill_color.pdf b/test/text/multi_cell_markdown_with_fill_color.pdf
diff --git a/test/text/multi_cell_markdown_with_ttf_fonts.pdf b/test/text/multi_cell_markdown_with_ttf_fonts.pdf
diff --git a/test/text/multi_cell_newpos.pdf b/test/text/multi_cell_newpos.pdf
diff --git a/test/text/multi_cell_table_unbreakable.pdf b/test/text/multi_cell_table_unbreakable.pdf
diff --git a/test/text/multi_cell_table_unbreakable2.pdf b/test/text/multi_cell_table_unbreakable2.pdf
diff --git a/test/text/multi_cell_table_unbreakable_with_split_only.pdf b/test/text/multi_cell_table_unbreakable_with_split_only.pdf