Fix non commutative operators (__rsub__, __rdiv__) #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2019 19:48
Previously, the expression 0 - Money(5, 'USD') would have returned Money(5, 'USD'), which was incorrect and unexpected, as the correct answer should've been Money(-5, 'USD')
Previously, division operations like 5 / Money(10, 'USD') would've given an incorrect result (2 instead of 0.5). Now, this operation raises a TypeError instead, as dividing non-Money by Money makes no sense dimension-wise.
|
Thanks for PR. Build was broken on master, but is fixed now. Could you merge from master so that the CI will run again? |
|
Thanks for fixing master, I've updated my branch against master and the CI should be passing now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, doing operations like
0 - Money(5)or5 / Money(2)will silently produce buggy results, as these operations have been implemented to be equivalent to their forward operations. As these operations are not commutative, the result was incorrect.With this PR, doing these operations raises TypeError instead, as doing those operations usually don't really make much sense.