Remove codeclimate #379
Merged
Remove codeclimate #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDrike
added
p: 2 - normal
ItsDrike
force-pushed
the
remove-codeclimate
branch
from
349eb22 to
e131bab
Compare
ItsDrike
force-pushed
the
remove-codeclimate
branch
from
e131bab to
430405c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, codeclimate was causing more problems than the benefits we got from it. This PR removes codeclimate from the repository entirely. This will mean that we'll no longer be uploading coverage reports, get some code analysis insights for common issues and get PR checks if a PR significantly decreased test coverage.
The insights from codeclimate aren't that relevant to us anyways, as we have ruff linter, which catches most of these already anyways. The coverage decrease check was neat though, but it also isn't all that necessary, as we can just make that a part of the review process, checking whether tests were included or not.