Add :Octo pr runs command

[wd60622]

Describe what this PR does / why we need it

Expose the branch in the list function which is used in new command :Octo pr runs to get the runs associated with the PR.

In this case, the value in the picker are all the same. Would it make sense to show the workflow name instead of the branch name? That is what comes from gh run list --branch pr-runs --json workflowName

For instance, this run would be labeled "Sync Closing Labels"

CC: @GustavEikaas

Does this pull request fix one issue?

Closes #910

Describe how you did it

Describe how to verify it

Special notes for reviews

Checklist

• Passing tests and linting standards
• Documentation updates in README.md and doc/octo.txt

[GustavEikaas]

Looks good!

One thing however;

You are passing branch to the filter for displaying workflows related to a pr. This will return all workflows run on this branch. Including the ones that have been run with triggers like

workflow_dispatch:

Is that intentional?

EDIT:
It makes sense IMO just sanity checking.

[GustavEikaas]

In this case, the value in the picker are all the same. Would it make sense to show the workflow name instead of the branch name? That is what comes from gh run list --branch pr-runs --json workflowName
For instance, this run would be labeled "Sync Closing Labels"

Yes definitely, very confusing when you list wf runs for a PR and they are all named the same

EDIT: I would use the json field name to get the run-name instead of the workflow name
The name property seems to take the workflowName if there is no run-name defined

[wd60622]

I was playing around with it and came to same conclusion in 9aec991

[wd60622]

You are passing branch to the filter for displaying workflows related to a pr. This will return all workflows run on this branch. Including the ones that have been run with triggers like

workflow_dispatch:

Is that intentional?

Yeah, I think that is probably fine

[wd60622]

I think it might make sense to have name even for the larger run list? What are your thoughts? Maybe prepend name to what is already being displayed? Bit separate so can address that some other time..

[GustavEikaas]

What we could do as an overall improvement is this. This would allow you to easily see the branch name it was executed on without scrolling

 local display
      if opts.branch == nil then
        display = string.format("%s (%s), value.name, value.headBranch)
      else
        display = value.name
      end

Kinda similar to how the github web UI does it

[GustavEikaas]

Awesome! LGTM🚀

[wd60622]

I've added that in in 483e424 . I tend to search by the "name" on the workflow

Let me know how this looks to you

[wd60622]

Thanks for the feedback @GustavEikaas !

[GustavEikaas]

Remember to update readme