Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support label multiselection #722

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Conversation

wd60622
Copy link
Collaborator

@wd60622 wd60622 commented Dec 15, 2024

Describe what this PR does / why we need it

Allows user to allow multiselect for adding and removing labels

Related to #675

Does this pull request fix one issue?

Describe how you did it

  • Adapt the graphql command to pass list of labelIds
  • Generalize telescope logic to grab multiple selection and check if non-empty
  • Use callback on list of labels including list of single label

Describe how to verify it

For telescope, use <Tab> to select multiple labels (while adding or removing) then press enter to confirm. If Tab is not pressed, then the behavior will be the same as before.

Special notes for reviews

Telescope only. However, fzf had support before but the cb was changed to support batch label add.

Checklist

  • Passing tests and linting standards
  • Documentation updates in README.md and doc/octo.txt

@wd60622 wd60622 changed the title Support label multiselectiono Support label multiselection Dec 15, 2024
@wd60622 wd60622 marked this pull request as ready for review December 15, 2024 23:43
@wd60622 wd60622 requested a review from pwntester December 15, 2024 23:55
@wd60622 wd60622 added enhancement New feature or request command Dealing with Octo commands labels Dec 15, 2024
@wd60622 wd60622 added the telescope Related to telescope picker label Dec 15, 2024
@wd60622
Copy link
Collaborator Author

wd60622 commented Dec 16, 2024

Luckily reviewers and assignees is very similar. Will address in the near future as well

@wd60622 wd60622 requested review from GuillaumeLagrange and removed request for GuillaumeLagrange December 16, 2024 11:50
@wd60622 wd60622 added command Dealing with Octo commands telescope Related to telescope picker and removed command Dealing with Octo commands telescope Related to telescope picker labels Dec 16, 2024
@wd60622 wd60622 added bug Something isn't working and removed telescope Related to telescope picker labels Dec 16, 2024
@wd60622 wd60622 merged commit 82ebba2 into pwntester:master Dec 16, 2024
2 checks passed
@wd60622 wd60622 deleted the multiselect-labels branch December 16, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working command Dealing with Octo commands enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant