Use plenary sync job to get local file content #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-to-fetch-from-commit-at-random-times-1
wd60622
deleted the
608-empty-content-in-diff-buffer-when-trying-to-fetch-from-commit-at-random-times-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #608
I gave up on trying to troubleshoot async plenary, and switched to sync, this fixes the empty diff buffer for local mode that is quite hard to reproduce.
Since this is a local git command, and, impact should be minimal, and the only caller of this function waits for the job to be done anyway by calling vim.wait on a condition that is done by the callback