feat(picker): add config options for changing mappings #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Adds config options to change the telescope or fzf-lua mappings.
Does this pull request fix one issue?
Fixes #447
Describe how you did it
I added the the config options and used them in the telescope and fzf-lua picker code. I added a util, along with spec tests, that converts vim style mappings to fzf ones.
Describe how to verify it
Change
pwntester/octo.nvim
tobenelan/octo.nvim
in your Neovim plugin configAdd the following to your Octo config
Open an Octo telescope or fzf-lua picker, e.g.
Octo pr list
Verify that the mappings are triggered with alt instead of ctrl (which is the default)
Special notes for reviews
The
desc
property isn't used, but I added it to match the format of the other mappings in the config. Plus, Telescope may add the ability to use thedesc
for<C-/>
some day.Let me know if you'd like me to change anything about the config options I added, thanks for the review!