Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #424
Adjusting the
get_background_color_of_highlight_group
function to support cleared highlight groups.highlight_group_normal.foreground
is both confusing and makes it impossible to overwrite the default background value to a null value. So I've removed it.OctoEditable
highlight but the previous logic would still add a color back.Does this pull request fix one issue?
Resolves #424
Special notes for reviews
Please let me know if the black background was intentional. And if so, what I would need to do to allow the
get_background_color_of_highlight_group
to return a cleared value so I can get a transparent UI.