Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request - movement to go to next comment in issue buffer #123

Closed
weilbith opened this issue Mar 9, 2021 · 3 comments
Closed

Feature request - movement to go to next comment in issue buffer #123

weilbith opened this issue Mar 9, 2021 · 3 comments
Assignees
@pwntester
Labels
enhancement New feature or request

Comments

@weilbith
Copy link
Contributor

weilbith commented Mar 9, 2021

Well, the title basically states it all. Maybe we can just "abuse" the extmarks for that, taking the current location and search for the next header extmark.
@pwntester pwntester added the enhancement New feature or request label Mar 10, 2021
pwntester added a commit that referenced this issue Mar 26, 2021
@pwntester
Implement #123: Move to next/prev comment in issue/pr buffer
0c9c152
@pwntester pwntester self-assigned this Mar 26, 2021
@pwntester
Copy link
Owner

Implemented in 0c9c152

@weilbith
Copy link
Contributor Author

weilbith commented Apr 5, 2021

Can this be easily extended for reviews? I mean if I'm doing a review and have the diff view, could we have a similar movement command to go to the next comment that is pending or what ever?
Is this a complete new issue (I would assume so) or could it be a simple extension of the existing functionality you added here? 🤔

@pwntester
Copy link
Owner

Pending comments can still be reviewed with Octo review comments, but yep, a ]p/[p mappings can be added to navigate through pending comments on the same file. Please file a new bug for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pwntester pwntester

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pwntester @weilbith