Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - assist the user which lines he can select for review comments/suggestions #108

Closed
weilbith opened this issue Mar 1, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request UI

Comments

@weilbith
Copy link
Contributor

weilbith commented Mar 1, 2021

When I select lines to comment or make a suggestion for, I sometimes get errors because the selection was too big. GH only allows to select lines somehow relative to changed hunks. For the user this is not obvious to see and know what he can select and what not. It would be cool if we could figure out an approach how to assist the user here. But I don't know if such information is actually available.
If it should be possible to somehow get this information which lines are selectable, my proposal would be to add a sign into the sign column for these lines. Something super simple like a bar in the color of the change (added, changed, ...).

@pwntester pwntester added enhancement New feature or request UI labels Mar 1, 2021
@pwntester pwntester self-assigned this Mar 27, 2021
@pwntester
Copy link
Owner

Implemented in #6ee8741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI
Projects
None yet
Development

No branches or pull requests

2 participants