Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable_on_hide bugs #87

Closed
pwkip opened this issue Sep 17, 2021 · 3 comments
Closed

disable_on_hide bugs #87

pwkip opened this issue Sep 17, 2021 · 3 comments
Labels
bug

Comments

@pwkip
Copy link
Owner

pwkip commented Sep 17, 2021 •
edited
Loading

When a field inside a group with the disable_on_hide prop is used in a condition, weird stuff happens. Needs to be fixed and create e2e tests.

ISSUE 1 : https://conditional-fields-cf7.bdwm.be/form-tester/?test-form=Github+issue+87

✅ Fixed in 2.1.1. Because a field is considered non-existing when it's disabled, the conditions with such a field make no sense. The behaviour for now is that the group will always be visible, if the condition has a non-existing field.
@pwkip pwkip added the bug label Sep 17, 2021
@pwkip
Copy link
Owner Author

pwkip commented Dec 19, 2021 •
edited
Loading

Additional disable_on_hide bug: when a repeater is inside a group with disable_on_hide, the new sub-repeaters will be disabled. When you hide the group and then show it again, all fields become enabled again.

ISSUE 3 : https://conditional-fields-cf7.bdwm.be/form-tester/?test-form=Github+issue+87+%283%29

✅ Fixed in 2.1.1

@pwkip pwkip changed the title disable_on_hide bug disable_on_hide bugs Dec 19, 2021
@pwkip
Copy link
Owner Author

pwkip commented Jan 29, 2022 •
edited
Loading

One more issue: it's possible to submit empty required fields when the parent group has the disable_on_hide property.
ISSUE 2 : https://conditional-fields-cf7.bdwm.be/form-tester/?test-form=Github+issue+87+%282%29

✅ Fixed in 2.1.1

@pwkip pwkip closed this as completed Feb 13, 2022
pwkip added a commit that referenced this issue Feb 13, 2022
@pwkip
= 2.1.1 (2022-02-14) =
3b1d939 
* Fully tested with Contact Form 7 version 5.5.5
* Make scroll to success message less annoying. [GH Issue 90](#90)
* Add extra check to make sure that scroll to success message only happens when the e-mail is sent. [GH Issue 90](#90)
* PRO: fix disable_on_hide bugs. [GH sssue 87](#87)
@pwkip
Copy link
Owner Author

pwkip commented Apr 16, 2022 •
edited
Loading

It's possible to move to next step when the parent group has the disable_on_hide property.

ISSUE 4: https://conditional-fields-cf7.bdwm.be/form-tester/?test-form=Github+issue+87+%284%29

✅ Fixed in 2.1.3

@pwkip pwkip reopened this Apr 16, 2022
@pwkip pwkip closed this as completed Apr 16, 2022
pwkip added a commit that referenced this issue Apr 18, 2022
@pwkip
= 2.1.3 (2022-04-18) =
5b3cb5c 
* check for user_cap 'wpcf7_edit_contact_forms' instead of 'wpcf7_edit_contact_form' in several places. Thanks, [@PayBox](https://wordpress.org/support/topic/some-notices-appearing-fix-suggested/)!
* PRO multistep: make "Next step" and "Previous step" buttons translatable by third party plugins like wpml and loco translate.
* PRO multistep: show spinner while validating a step.
* PRO Fix additional disable_on_hide bug with multistep [GH issue 87-4](#87)
* Replace all occurences of text domain 'contact-form-7' with 'cf7-conditional-fields'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pwkip