libostree: Ensure progress keys are all always set

If one of the progress keys is set in a pull operation, a ::changed signal is emitted on the progress object, and the callback for that could query any of the progress keys — so they all need to be set, otherwise we get an assertion failure in ostree_async_progress_get() due to a named key not existing. Spotted by Dan Nicholson in PR ostreedev#819. Signed-off-by: Philip Withnall <[email protected]>
pwithnall · May 5, 2017 · 0d521ca · 0d521ca
1 parent 64322c7
commit 0d521ca
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/libostree/ostree-repo-pull.c b/src/libostree/ostree-repo-pull.c
@@ -3477,6 +3477,9 @@ ostree_repo_pull_with_options (OstreeRepo             *self,
       guint shift; 
       GString *buf = g_string_new ("");
 
+      /* Ensure the rest of the progress keys are set appropriately. */
+      update_progress (pull_data);
+
       if (bytes_transferred < 1024)
         shift = 1;
       else