Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyvenv integration #48

Merged
merged 1 commit into from
Mar 4, 2019
Merged

pyvenv integration #48

merged 1 commit into from
Mar 4, 2019

Conversation

inpefess
Copy link
Contributor

@inpefess inpefess commented Mar 4, 2019

What changes are proposed in this PR

  • use pyvenv to switch virtualenvs
  • remove pipenv.el original functions for switching virtualenvs

How this PR was tested

  • manually (switching projects and running Python tests by C-c C-t)
  • in CircleCI (existing tests were extended)

What issues/PRs are related to this PR

Pyvenv integration was proposed in #22, #23 was related with inability to run tests, and #42 proposed another solution (extending pipenv functions for switching venvs, not removing them).

@pwalsh
Copy link
Owner

pwalsh commented Mar 4, 2019

Great work @inpefess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants