Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix big-endian buffer not supported on little-endian compiler bug #921

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

kahemker
Copy link
Contributor

Issue #920 fully describes the problem and links to a Stack Overflow post where another user ran into the same problem.

@CameronTStark CameronTStark added this to the 0.7.3 milestone Mar 3, 2020
@wholmgren wholmgren modified the milestones: 0.7.3, 0.8.0 Jul 17, 2020
@wholmgren
Copy link
Member

@kahemker sorry for the delay here. Are you able to address the stickler-ci errors? If not, I can clean up and merge.

The rest of the checklist is optional for this PR.

kahemker added 2 commits July 17, 2020 16:47
Resolve Stickler CI checks
Remove trailing white space
@kahemker
Copy link
Contributor Author

@wholmgren No problem. I didn't notice the stickler-ci errors. First time contributing. How's it look now?

Copy link
Member

@wholmgren wholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kahemker!

Note to other maintainers: I'm approving this without a test because I don't know how to do it. We can add one in a future PR if anyone has ideas.

@wholmgren wholmgren merged commit a1e8134 into pvlib:master Jul 17, 2020
@kahemker kahemker deleted the big-endian-buffer-bug branch August 15, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: Big-Endian buffer not supported on little-endian compiler
3 participants