Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated use of pkg_resources API #1881

Closed
Peque opened this issue Sep 28, 2023 · 0 comments · Fixed by #1882
Closed

Remove deprecated use of pkg_resources API #1881

Peque opened this issue Sep 28, 2023 · 0 comments · Fixed by #1882
Labels
testing
Milestone
v0.10.3

Comments

@Peque
Copy link
Contributor

Peque commented Sep 28, 2023

The setuptools page states that the use of pkg_resources is deprecated.

This can lead to warnings like:

image

It seems the package is only imported for using parse_version. In the same setuptools page, they suggest:

[...] Some useful APIs are also provided by packaging (e.g. requirements and version parsing). [...]

So in order to avoid this warnings (and possibly future failures), parse_version should be replaced by its packaging alternative.

The packaging package is already installed with test dependencies so it will not add any new extra "weight", but it should be added explicitly to the setup.py file.
Peque added a commit to Peque/pvlib-python that referenced this issue Sep 28, 2023
@Peque
Replace use of deprecated pkg_resources (pvlib#1881)
dfc458c
@Peque Peque mentioned this issue Sep 28, 2023
Merged
8 tasks
@kandersolar kandersolar added this to the v0.10.3 milestone Oct 3, 2023
Peque added a commit to Peque/pvlib-python that referenced this issue Oct 4, 2023
@Peque
Replace use of deprecated pkg_resources (pvlib#1881)
0053366
Peque added a commit to Peque/pvlib-python that referenced this issue Oct 4, 2023
@Peque
Replace use of deprecated pkg_resources (pvlib#1881)
640887f
kandersolar pushed a commit that referenced this issue Oct 4, 2023
@Peque
Replace use of deprecated pkg_resources (#1881) (#1882)
e36e50a
kandersolar added a commit that referenced this issue Nov 29, 2023
@kandersolar @eumiro
@akeeman @Peque @williamhobbs @adriesse @cwhanse @AdamRJensen @matsuobasho
JOSS-review: comparison to other tools (#1912)
f691864 
* Remove various repeated words in documentation (#1872)

* Remove repeated words

* Update pvlib/ivtools/sdm.py

Co-authored-by: Kevin Anderson <[email protected]>

---------

Co-authored-by: Kevin Anderson <[email protected]>

* fix invalid escape sequence '\c' (#1879)

* fix invalid escape sequence '\c'

pvlib/iam.py:843: DeprecationWarning: invalid escape sequence '\c'

Occurence is actually in line 854: `IAM = 1 - (1 - \cos(aoi))^5`

* Add to list of contributors

* Replace use of deprecated `pkg_resources` (#1881) (#1882)

* Update infinite_sheds.py to add shaded fraction to returned variables in infinite_sheds.get_irradiance and infinite_sheds.get_irradiance_poa (#1871)

* Update infinite_sheds.py

Added shaded fraction to returned variables.

* Update v0.10.3.rst

* Update test_infinite_sheds.py

added tests for shaded fraction

* Update test_infinite_sheds.py

Corrected the shaded fraction tests in the haydavies portion.

* Update pvlib/bifacial/infinite_sheds.py

Co-authored-by: Kevin Anderson <[email protected]>

* Update infinite_sheds.py

* Update infinite_sheds.py

* Update infinite_sheds.py

fixed indentation issues

---------

Co-authored-by: Kevin Anderson <[email protected]>

* Continuous version of the Perez transposition model implementation (#1876)

* Definitely not ready for review!

* Big step forward.

* Add entry in docs.

* A working model but just one test sofar.

* Add new model as option in get_sky_diffuse.  Docstring edits pending.

* Completed doc strings.  Also a bit of fine-tuning code.

* Updated whatsnew.

* Bugfix, formatting fix, and add all tests.

* Test warning plus some other small changes.

* Make flake happy.

* Update pvlib/irradiance.py

Co-authored-by: Cliff Hansen <[email protected]>

* Address comments.

* Add contributor code comments.

* Update pvlib/irradiance.py

Co-authored-by: Adam R. Jensen <[email protected]>

* Adapt to reviewer preferences.

* Adapt to flake preferences.

* Remove model pseudo-option.

* Flake

---------

Co-authored-by: Cliff Hansen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>

* Fix spurious test error with pandas 2.1 (#1891)

pandas-dev/pandas#55014

* Fix plotting in plot_singlediode.py gallery page (#1895)

* Update plot_singlediode.py

fixed plot annotations by moving plt.show() further down

* Update whatsnew.rst

* Update v0.10.3.rst

* Update docs/sphinx/source/whatsnew.rst

Undoing changes to whatsnew.rst

* Address pandas FutureWarnings in test suite (#1900)

* Cahnged expected reference in test_detect_clearskY_window to 1 from True to avoid Futurewarning

* Change reference to etr in ibird function to avoid FutureWarning

* In test_modelchain, update all instances when referring to series by position to using iloc to get rid of FutureWarning

* Update to iloc method for referencing by position in test_irradiance to get rid of FutureWarning

* In test_singlediode change applymap to map to get rid of FutureWarning

* Test_srml update to select using iloc to get rid of FutureWarning

* Substitute changing to float64 dtype using map with base functionality that's accessible across Pandas versions

* Added username to Contributors

* Update line break in test_clearsky to adhere to line length limit

* add comparisons to other tools

* Apply suggestions from code review

Co-authored-by: Cliff Hansen <[email protected]>

* revision re: other open-source projects

* bibtex tweaks

* clarify pvlib matlab comparison

---------

Co-authored-by: Miroslav Šedivý <[email protected]>
Co-authored-by: Arjan Keeman <[email protected]>
Co-authored-by: Miguel Sánchez de León Peque <[email protected]>
Co-authored-by: Will Hobbs <[email protected]>
Co-authored-by: Anton Driesse <[email protected]>
Co-authored-by: Cliff Hansen <[email protected]>
Co-authored-by: Adam R. Jensen <[email protected]>
Co-authored-by: matsuobasho <[email protected]>
@kandersolar kandersolar mentioned this issue Feb 8, 2024
Merged
3 tasks
@kandersolar kandersolar mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
v0.10.3
Development

Successfully merging a pull request may close this issue.

Replace use of deprecated pkg_resources (#1881) Peque/pvlib-python
2 participants
@Peque @kandersolar