-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto redirect on login page #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-illi
force-pushed
the
feature/auto-redirect-login-59739
branch
2 times, most recently
from
September 21, 2022 06:41
d9a93f2
to
e1e286a
Compare
Kagemaru
reviewed
Sep 21, 2022
Comment on lines
13
to
33
def local_auth? | ||
Settings.auth.db.active | ||
end | ||
|
||
def omniauth_providers | ||
Settings.auth&.omniauth&.map(&:second)&.map(&:active) | ||
end | ||
|
||
def single_omniauth_provider? | ||
omniauth_providers&.one? | ||
end | ||
|
||
def auto_login_disabled? | ||
ActiveRecord::Type::Boolean.new.deserialize(params[:prevent_auto_login]) || false | ||
end | ||
|
||
def auto_redirect? | ||
!auto_login_disabled? && !local_auth? && single_omniauth_provider? | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduction of the double negatives
Suggested change
def local_auth? | |
Settings.auth.db.active | |
end | |
def omniauth_providers | |
Settings.auth&.omniauth&.map(&:second)&.map(&:active) | |
end | |
def single_omniauth_provider? | |
omniauth_providers&.one? | |
end | |
def auto_login_disabled? | |
ActiveRecord::Type::Boolean.new.deserialize(params[:prevent_auto_login]) || false | |
end | |
def auto_redirect? | |
!auto_login_disabled? && !local_auth? && single_omniauth_provider? | |
end | |
def no_local_auth? | |
!Settings.auth.db.active | |
end | |
def omniauth_providers_active | |
Settings.auth&.omniauth&.map(&:second)&.map(&:active) | |
end | |
def single_omniauth_provider? | |
omniauth_providers_active&.one? | |
end | |
def auto_login_enabled? | |
return true unless prevent = params[:prevent_auto_login] | |
!ActiveRecord::Type::Boolean.new.deserialize(prevent) | |
end | |
def auto_redirect? | |
auto_login_enabled? && no_local_auth? && single_omniauth_provider? | |
end | |
daniel-illi
force-pushed
the
feature/auto-redirect-login-59739
branch
from
November 14, 2022 13:58
e1e286a
to
1022337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #59739