Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate contact email syntax, fixes #46693 #163

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

daniel-illi
Copy link
Member

No description provided.

@daniel-illi daniel-illi requested a review from Kagemaru April 5, 2022 09:28
Copy link
Member

@Kagemaru Kagemaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

app/models/util/email_validator.rb Outdated Show resolved Hide resolved
@@ -15,3 +15,5 @@ de-CH:
login:
ldapname_not_found:
'Der Member mit dem LDAP Name: "%{ldapname}" konnte nicht gefunden werden.'
message:
invalid_email: 'ist keine gültige Email Adresse'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leere Zeile am Ende der Datei

Suggested change
invalid_email: 'ist keine gültige Email Adresse'
invalid_email: 'ist keine gültige Email Adresse'

@daniel-illi daniel-illi force-pushed the feature/validate-contact-email-46693 branch from 61267f3 to faf21ca Compare April 11, 2022 09:24
@daniel-illi daniel-illi force-pushed the feature/validate-contact-email-46693 branch from faf21ca to 8238950 Compare April 11, 2022 09:28
@daniel-illi daniel-illi merged commit da933bd into master Apr 11, 2022
@daniel-illi daniel-illi deleted the feature/validate-contact-email-46693 branch April 12, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants