Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Berachain support to SDK #1128

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Add Berachain support to SDK #1128

merged 5 commits into from
Mar 19, 2024

Conversation

pratham-bhatnagar
Copy link
Contributor

Closes #1127

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Copy link

The code in the specified files looks good.

@Aman035 Aman035 self-requested a review March 19, 2024 09:14
Copy link

All looks good.

@Aman035 Aman035 marked this pull request as ready for review March 19, 2024 12:42
@Aman035 Aman035 merged commit 7c569ee into main Mar 19, 2024
2 checks passed
Copy link

There are some issues found in the code:

  1. In .husky/pre-commit, the script should include shebang at the top #!/bin/sh and correct the yarn commands to include run before the script name, for example yarn run cleanbuild, yarn run nx affected --target=lint, yarn run nx affected --target=test.

  2. In packages/examples/sdk-frontend-react/src/app/components/Connect.tsx, the StyledButton and Connect styled components are missing closing curly braces }. Also, the Disconnect styled component should have a closing curly brace as well.

  3. In packages/examples/sdk-frontend-react/src/app/helpers.ts, the AddressValidatorsType interface is missing a closing curly brace }. The isValidETHAddress function is missing a closing curly brace }. Additionally, the validateCAIP function is missing a closing curly brace }.

  4. In packages/restapi/src/lib/config.ts, in the definition of berachainTestnet object, the blockExplorers object is missing a closing curly brace }.

  5. In packages/restapi/src/lib/constants.ts, the Constants object is missing a closing curly brace } at the end.

Once these fixes are applied, the code should be reviewed again.

Copy link

There are a few issues found in the code:

  1. In the .husky/pre-commit file, the yarn cleanbuild command should be yarn build or yarn clean && yarn build depending on the intended behavior.

  2. In the packages/examples/sdk-frontend-react/src/app/components/Connect.tsx file, the StyledButton component is missing a closing curly brace for the styled.button CSS definition.

  3. In the packages/examples/sdk-frontend-react/src/app/helpers.ts file, the isValidETHAddress function is missing a closing curly brace. Additionally, the validateCAIP function is missing a closing curly brace in the AddressValidators object.

  4. In the packages/restapi/src/lib/config.ts file, the defineChain function for berachainTestnet is missing a closing curly brace and there are missing comma separators between the block explorers and testnet properties.

After fixing the above issues, the code looks good.

All looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👾 [Other] - Add Berachain to SDK
2 participants