Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React native UI and SDK packages #1034

Conversation

kalashshah
Copy link
Contributor

Fixes Issue

#983

Changes proposed

  1. React native UI package
  2. React native example application

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

In the .gitignore file, everything looks good.

In the build.gradle file, the comments are incomplete and not formatted correctly. Please update the comments to make them more informative and readable.

In the MainApplication.java file, there is a missing closing brace for the getPackages() method. Please add a closing brace after the return packages; statement.

In the AppDelegate.h file, there is a missing closing angle bracket (>) in the #import statement. Please add the closing angle bracket at the end of the statement.

In the AppDelegate.mm file, there is a missing semi-colon (;) at the end of the #import statement. Please add a semi-colon at the end.

Overall, the code looks good.

Copy link

In the file packages/examples/sdk-react-native/android/app/build.gradle:

  • Line 83: There is a closing parenthesis missing after android
  • Line 111: There is an extra closing parenthesis after keyPassword 'android'

In the file packages/examples/sdk-react-native/android/app/src/main/AndroidManifest.xml:

  • Line 20: There is a typo in the attribute name android:name=".MainApplication". It should be android:name=".MainActivit

In the file packages/examples/sdk-react-native/android/app/src/main/java/com/rnsdktest/MainActivity.java:

  • Line 19: There is a comment that is not properly closed. The line should start with /* instead of *

In the file packages/examples/sdk-react-native/android/app/src/main/java/com/rnsdktest/MainApplication.java:

  • Line 23: The method getPackages() is not properly closed. It should have a closing parenthesis } at the end.
  • Line 26: The method getJSMainModuleName() is not properly closed. It should have a closing parenthesis } at the end.
  • Line 30: The method isNewArchEnabled() is not properly closed. It should have a closing parenthesis } at the end.
  • Line 36: The method isHermesEnabled() is not properly closed. It should have a closing parenthesis } at the end.
  • Line 54: There is an extra closing parenthesis after return BuildConfig.IS_HERMES_ENABLED;

In the file packages/examples/sdk-react-native/package.json:

  • The file is missing a closing parenthesis } at the end.

All other files look good.

@kalashshah kalashshah requested a review from HarshRajat January 17, 2024 12:59
@push-protocol push-protocol deleted a comment from github-actions bot Jan 18, 2024
@push-protocol push-protocol deleted a comment from github-actions bot Jan 18, 2024
Copy link

All looks good.

@kalashshah kalashshah changed the title UI React Native package React native UI and SDK packages Feb 21, 2024
@kalashshah kalashshah closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Improvement Proposal] - UI React Native package and component like UIWeb
1 participant