DAPP-1981-added new rivo channel activity

[rohitmalhotra1420]

Pull Request Template

Ticket Number

• 1981

Description

• Added new rivo channel activity for the reward points activity page

• Problem/Feature:

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

In the file src/modules/rewards/components/RewardsActivityIcon.tsx, there are several issues:

1. Missing return keyword in the conditional blocks for rendering components based on the type. Add return before each component.
2. In the conditional block for type === 'follow_push_on_twitter', the component is not returned. Add return before <Twitter.
3. There are multiple conditional blocks with missing return keyword, fix all of them.
4. Image elements are used directly within the component without proper usage, such as sourcing the image for specific types. Use the src attribute within the <img> tags and return them properly.

After fixing the above issues, the component should be properly returning the corresponding components or images based on the type.

In the other files, everything seems correct, including the src/common/Common.baseLogos.ts, src/modules/rewards/utils/activityTypeArray.ts, and src/queries/types/rewards.ts.

Your code review is complete. If you have any questions or need further assistance, feel free to ask.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-12-10 14:37 UTC