Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dashboard Channel #1938

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

#1937

Description

  • Problem/Feature:
  • Replace Cyber with PWN

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Oct 28, 2024 that may be closed by this pull request
Copy link

  • The import statements at the beginning are duplicated.
  • The useEffect hook inside the useStakeRewardsResetTime function is missing dependencies: isWalletConnected, isLoadingPushStakeData, isLoadingPushUniData, sendRecentActivities. These should be added as dependencies to avoid potential bugs.

All looks good.

Copy link

github-actions bot commented Oct 28, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-28 10:52 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit fcfb119 into main Oct 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Dashboard Channels
2 participants