Update Rewards Activities

[corlard3y]

Pull Request Template

#1935

Description

• Problem/Feature:

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):
  Add to rewards activities list

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

In the RewardsActivityIcon.tsx file, there are multiple issues:

1. Missing return keyword in if statements:

   if (type === 'follow_push_on_twitter') {
       return <Twitter />;
   }
   if (type === 'create_gated_group_push_chat') {
       return <GatedGroupPoints />;
   }

2. Missing return keyword for other condition statements:

   if (type === 'channel_specific_subscriptions:WALLETTRACKER_CHANNEL') {
       return <img src={walletTrackerLogo} style={{ borderRadius: 'var(--radius-round)' }} />
   }

3. Fix for multiple conditions missing return statements in the rest of the file.

Please ensure that all conditional statements within the RewardsActivityIcon component return JSX elements.

Known typo:
ActvityType in src/modules/rewards/utils/activityTypeArr.ts should be corrected to ActivityType.

All looks good.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-24 16:30 UTC