Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new UI for notification settings page #1825

Closed

Conversation

abhishek-01k
Copy link
Collaborator

Pull Request Template

Ticket Number

#1785

Description

New UI for Notification settings page.

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

https://www.figma.com/design/FvJL0JWHlsVohsHTERB1Lh/Push-Design-Foundations?node-id=6658-9557&m=dev

  • Before: Old UI

  • After: New UI according to the figma above

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

You should have a channel. Click on Add or Manage notification settings and then you will see the new UI for the notification settings page.

Copy link

All looks good.

@abhishek-01k abhishek-01k changed the base branch from channel-flow to main August 22, 2024 23:49
Copy link

All looks good.

@abhishek-01k abhishek-01k changed the base branch from main to channel-flow August 22, 2024 23:51
Copy link

Please provide the files that need to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant