Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards QA minor fixes #1734

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Rewards QA minor fixes #1734

merged 2 commits into from
Jul 16, 2024

Conversation

corlard3y
Copy link
Collaborator

Pull Request Template

#1728

Description

  • Hide -1 for the leaderboard

  • Format comma in the Leaderboard section

  • Scroll visible only on hover temporary fix

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@corlard3y corlard3y linked an issue Jul 15, 2024 that may be closed by this pull request
Copy link

All looks good.

@corlard3y corlard3y changed the title 1728 rewards qa minor fixes Rewards QA minor fixes Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-16 09:30 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit 6dda889 into main Jul 16, 2024
2 of 3 checks passed
corlard3y added a commit that referenced this pull request Jul 16, 2024
* fix leaderboard issues

* add scroll bar visible
corlard3y added a commit that referenced this pull request Jul 16, 2024
* fix leaderboard issues

* add scroll bar visible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Feature Enhancement] - <Rewards QA minor fixes>
3 participants