Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DApp-1639 update buttons ui and support dark mode #1681

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

kalashshah
Copy link
Contributor

Pull Request Template

Ticket Number

Description

  • Problem/Feature:
  • Update button colors
  • Support dark mode in buttons

Type of Change

  • Other (please describe): UI changes

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

image image

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

github-actions bot commented Jul 1, 2024

In the Button.constants.ts file:

  • The case 'primary' block is missing closing braces } for the background-color properties under the :active and :focus-visible states.
  • The case 'secondary' block is missing opening braces { before the background-color: ${getBlocksColor( property within the case block.
  • Similar issues exist for other case blocks like 'tertiary', 'danger', 'dangerSecondary', and 'outline'. Missing opening braces { and closing braces } in various places.

In the Button.tsx file:

  • In the StyledButton component, there is a reference to --r10 which is not defined in the provided CSS.
  • The Button component is missing a closing brace } after the return statement inside the forwardRef function.

Overall, the code structure looks fine but there are some missing braces and undefined CSS variables in the provided code snippets.

All looks good.

Copy link

github-actions bot commented Jul 1, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-01 15:02 UTC

@rohitmalhotra1420 rohitmalhotra1420 changed the title chore: update buttons ui and support dark mode DApp-1639 update buttons ui and support dark mode Jul 1, 2024
Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image @kalashshah can you confirm this from Zee oncee, the recommended chat colour seems different than the one in figma

@kalashshah
Copy link
Contributor Author

image @kalashshah can you confirm this from Zee oncee, the recommended chat colour seems different than the one in figma

Zee mentioned that the colors were incorrect anyway, it is fine for now but needs to be changed to the correct colors later

@mishramonalisha76
Copy link
Collaborator

image @kalashshah can you confirm this from Zee oncee, the recommended chat colour seems different than the one in figma

Zee mentioned that the colors were incorrect anyway, it is fine for now but needs to be changed to the correct colors later

@kalashshah lets create an issue for the same

@kalashshah
Copy link
Contributor Author

Yeah already created: push-protocol/push-sdk#1373

@rohitmalhotra1420 rohitmalhotra1420 merged commit 57c3732 into main Jul 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dark Mode support and update current UI states in blocks/button
3 participants