Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the font-family #1674

Merged
merged 13 commits into from
Jul 10, 2024
Merged

Changed the font-family #1674

merged 13 commits into from
Jul 10, 2024

Conversation

mishramonalisha76
Copy link
Contributor

@mishramonalisha76 mishramonalisha76 commented Jun 26, 2024 •
edited
Loading

Pull Request Template

Ticket Number

Description

  • Problem/Feature:
    Changed the font-family from 'Strawford' to 'FK Grotesk Neu'
    Changed the letter-spacing to normal
    Change font sizes

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@mishramonalisha76 mishramonalisha76 self-assigned this Jun 26, 2024
@mishramonalisha76 mishramonalisha76 added the DO NOT MERGE If the PR/task is dependent on some other task add this label to the PR. label Jun 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-10 08:28 UTC

@rohitmalhotra1420 rohitmalhotra1420 linked an issue Jun 27, 2024 that may be closed by this pull request
Update font-family in DApp #1627
Closed
@rohitmalhotra1420 rohitmalhotra1420 merged commit 657fbf8 into main Jul 10, 2024
1 of 2 checks passed
corlard3y pushed a commit that referenced this pull request Jul 16, 2024
@mishramonalisha76 @corlard3y
Changed the font-family (#1674)
e7ed08b 
* added font files

* changed the font

* added the font files

* fixed font reviews

* added updated sdk version and fixed theming

* fixed fonts as per review

* added new sdk version

* updated to alpha version

* updated uiweb version to 1.4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitmalhotra1420 rohitmalhotra1420 rohitmalhotra1420 approved these changes

@zeepush zeepush Awaiting requested review from zeepush

Assignees

@mishramonalisha76 mishramonalisha76

Labels
DO NOT MERGE If the PR/task is dependent on some other task add this label to the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update font-family in DApp
2 participants
@mishramonalisha76 @rohitmalhotra1420