Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the icons in deactivate channel modal #1671

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fixed the icons in deactivate channel modal #1671

merged 1 commit into from
Jun 26, 2024

Conversation

mishramonalisha76
Copy link
Contributor

@mishramonalisha76 mishramonalisha76 commented Jun 25, 2024 •
edited
Loading

Pull Request Template

Ticket Number

Description

  • Problem/Feature:
    Fixed the icons in deactivate channel modal

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior
image
  • After: What's changed now
image

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@github-actions GitHub Actions
Copy link

All looks good.

@mishramonalisha76 mishramonalisha76 self-assigned this Jun 25, 2024
@mishramonalisha76 mishramonalisha76 linked an issue Jun 25, 2024 that may be closed by this pull request
🐛 [BUG] - Icon not rendering in deactivate channel modal #1665
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-26 04:58 UTC

@mishramonalisha76 mishramonalisha76 changed the title fixed the icons in deactibate channel modal fixed the icons in deactivate channel modal Jun 25, 2024
@rohitmalhotra1420 rohitmalhotra1420 merged commit 2fc2d80 into main Jun 26, 2024
2 of 3 checks passed
corlard3y pushed a commit that referenced this pull request Jul 1, 2024
@mishramonalisha76 @corlard3y
fixed the icons in deactibate channel modal (#1671)
db4a59e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitmalhotra1420 rohitmalhotra1420 rohitmalhotra1420 approved these changes

Assignees

@mishramonalisha76 mishramonalisha76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Icon not rendering in deactivate channel modal
2 participants
@mishramonalisha76 @rohitmalhotra1420