Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DApp-1551 blocks/Tooltip #1635

Merged
merged 10 commits into from
Jun 26, 2024
Merged

DApp-1551 blocks/Tooltip #1635

merged 10 commits into from
Jun 26, 2024

Conversation

kalashshah
Copy link
Contributor

Pull Request Template

Ticket Number

Description

Problem/Feature:

  • Create a reusable tooltip component according to the new design system.

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

image
image
image
image

Additional Context

NA

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

NA

@github-actions GitHub Actions
Copy link

There are no mistakes in the code provided. All looks good.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-26 08:42 UTC

rohitmalhotra1420
rohitmalhotra1420 requested changes Jun 17, 2024
View reviewed changes
src/hooks/useDimensions.tsx Outdated Show resolved Hide resolved
src/blocks/tooltip/Tooltip.types.ts Outdated Show resolved Hide resolved
src/blocks/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
src/blocks/tooltip/Tooltip.tsx Show resolved Hide resolved
@kalashshah kalashshah added the DApp - DS Label for tickets related to the design system for DApp label Jun 25, 2024
rohitmalhotra1420
rohitmalhotra1420 previously approved these changes Jun 25, 2024
View reviewed changes
src/blocks/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
src/blocks/tooltip/Tooltip.tsx Show resolved Hide resolved
src/blocks/tooltip/Tooltip.tsx Show resolved Hide resolved
src/blocks/tooltip/Tooltip.tsx Show resolved Hide resolved
src/blocks/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
src/blocks/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
src/blocks/tooltip/Tooltip.types.ts Outdated Show resolved Hide resolved
src/blocks/tooltip/Tooltip.types.ts Outdated Show resolved Hide resolved
src/blocks/tooltip/Tooltip.types.ts Outdated Show resolved Hide resolved
src/blocks/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
@rohitmalhotra1420 rohitmalhotra1420 self-requested a review June 25, 2024 09:12
@rohitmalhotra1420
Copy link
Collaborator

@kalashshah PR looks good to me. Please resolve the merge conflicts. I'll approve and merge after that.

@rohitmalhotra1420 rohitmalhotra1420 merged commit ffac83e into main Jun 26, 2024
1 of 2 checks passed
@rohitmalhotra1420 rohitmalhotra1420 linked an issue Jun 26, 2024 that may be closed by this pull request
[DApp - DS] Create Tooltip Component #1551
Closed
corlard3y pushed a commit that referenced this pull request Jul 1, 2024
@kalashshah @rohitmalhotra1420 @corlard3y
DApp-1551 blocks/Tooltip (#1635)
ba4af87 
* feat: tooltip blocks component

* chore: implement tooltip using radix tooltip

* chore: rename hook file extension

* updated lock file

* chore: basic style and func fixes

---------

Co-authored-by: rohitmalhotra1420 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitmalhotra1420 rohitmalhotra1420 rohitmalhotra1420 approved these changes

Assignees

@kalashshah kalashshah

Labels
DApp - DS Label for tickets related to the design system for DApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DApp - DS] Create Tooltip Component
2 participants
@kalashshah @rohitmalhotra1420