Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy.NonEmptyList cons #143

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Lazy.NonEmptyList cons #143

merged 3 commits into from
Sep 27, 2021

Conversation

matthewleon
Copy link
Contributor

No description provided.

@hdgarrood
Copy link
Contributor

👍 this seems sensible to me, but I think I’ll hold off on merging because I’m not familiar with lazy lists (confession: I’ve never actually used one!)

JordanMartinez
JordanMartinez approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation is correct AFAICT

@JordanMartinez
Copy link
Contributor

We still need a changelog entry here.

@JordanMartinez JordanMartinez merged commit 68bce83 into purescript:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanMartinez JordanMartinez JordanMartinez approved these changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewleon @hdgarrood @JordanMartinez @thomashoneyman