Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v0.14.0-rc3 #106

Merged
merged 3 commits into from
Nov 15, 2020
Merged

Update to v0.14.0-rc3 #106

merged 3 commits into from
Nov 15, 2020

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez
Copy link
Contributor Author

Currently blocked by exists and likely some kind signature warnings, but I won't know what they are until exists is updated.

@JordanMartinez JordanMartinez mentioned this pull request Nov 14, 2020
Closed
@JordanMartinez
Temporarily disable benchmarks
4171074 
`purescript-benchotron` is not a core repo. By including it here, this 
repo will never pass CI because benchotron will pull in non-master 
dependencies.

This should be re-added later.
@JordanMartinez
Copy link
Contributor Author

purescript-benchotron is not a core repo. By including it here, this repo will never pass CI because benchotron will pull in non-master dependencies.

This should be re-added later. Before merging this PR, we need to add an issue that tracks this.

Also, we will need to decide whether to merge #104 or not before or after this one.

@JordanMartinez JordanMartinez mentioned this pull request Nov 15, 2020
Closed
57 tasks
thomashoneyman
thomashoneyman approved these changes Nov 15, 2020
View reviewed changes
Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue to re-enable benchmarks after this closes and link it to an issue on benchotron for updating to 0.14?

@JordanMartinez JordanMartinez mentioned this pull request Nov 15, 2020
Open
@JordanMartinez
Copy link
Contributor Author

I've opened issues in this repo and the benchotron one.

@JordanMartinez JordanMartinez merged commit dc1bd3f into purescript:master Nov 15, 2020
@JordanMartinez JordanMartinez deleted the updateTo14 branch November 15, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordanMartinez @thomashoneyman @srghma