Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make <?> infixr and update prec to 2 #163

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Make <?> infixr and update prec to 2 #163

merged 2 commits into from
Mar 24, 2022

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Fixes #161


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added type: breaking change A change that requires a major version bump. purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 labels Mar 24, 2022
@JordanMartinez
Copy link
Contributor Author

🏓 @thomashoneyman

@thomashoneyman thomashoneyman merged commit edc61eb into purescript-contrib:main Mar 24, 2022
@JordanMartinez
Copy link
Contributor Author

I don't think setting <?> to 2 actually works.

@thomashoneyman
Copy link
Contributor

Wait, sorry — I was about to say the same thing 😓. This isn't exercised in tests at all in this library. We need to add it there. Sorry about that, I just assumed it was already used there and would have thrown.

@JordanMartinez
Copy link
Contributor Author

No worries! I'll submit another PR.

@JordanMartinez JordanMartinez mentioned this pull request Mar 24, 2022
4 tasks
@natefaubion
Copy link
Contributor

I actually think that this should be 3, on second thought. It having the same precedence as alt means that you can just write things like:

foo <?> "ok"
  <|> bar <?> "wat

Even if a formatter will mess it up.

@JordanMartinez JordanMartinez deleted the fix-alt-breakage branch March 24, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Development

Successfully merging this pull request may close these issues.

Fix issues caused by making <|> infixr
3 participants