-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v0.14.0-rc3 #20
Update to v0.14.0-rc3 #20
Conversation
Someone more familiar with this library should clarify whether we need these kind annotations to be polykinded or just kinded to |
@JordanMartinez I'm not completely confident, but I suspect these can all be fixed to |
.github/workflows/ci.yml
Outdated
@@ -9,26 +9,27 @@ on: | |||
jobs: | |||
build: | |||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs-on: ubuntu-latest | |
runs-on: ubuntu-latest | |
package.json
Outdated
"purescript-psa": "^0.8.0", | ||
"rimraf": "^3.0.2" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the other contrib repositories we've just updated the CI.yml file directly, without introducing Pulp to the project (or a new package.json file). Can we just update the Bower file and the ci.yml file instead of adding these new files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other words, the migration script for core / web / node isn't suitable for contrib.
How about now? |
CI builds now. |
Backlinking to purescript-contrib/governance#35